fix: Handled ctx=None for AvroDeserializer and ProtobufDeserializer #1974
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handled
None
value for optional parameter calledctx
in both AvroDeserializer and ProtobufDeserializer.closes #1939
closes #1973
The "optional"
ctx
parameter in__call__
method in AvroDeserializer and ProtobufDeserializer isn't optional at all... Despite method annotation that specifies type of this parameter asctx: Optional[SerializationContext] = None
is was required in the method logic andNone
value wasn't handled. This misbehavior (compered to previous releases) was already noticed in the issues mentioned above.This PR contains fix that handles None value and hence gives backward compatibility.
Checklist
References
GH:
Open questions / Follow-ups
If this behavior is intended for some reason I would suggest:
ctx
parameter