-
Notifications
You must be signed in to change notification settings - Fork 101
Add outbound_addr to allow for SNAT instead of MASQ #1180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lto-dev The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add proper integration test in test/
for both iptables and nftables
I have not yet looked into the rules that are added and if they are correct
Also I think this would need to be added to the firewalld code as well cc @mheon
let me know if the modifications are ok |
Note I do not have time to properly review the rules right now. However please make sure your commits make sense as individual unit. Currently they are pretty meaningless so I suggest you squash everything into one |
Signed-off-by: lto-dev <[email protected]>
Ephemeral COPR build failed. @containers/packit-build please check. |
Added outbound_addr to the bridge driver.
I created a bridge-snat plugin to use this feature and do SNAT instead of MASQUERADE on certain networks since i have multiple public ip's on same machine and i needed the traffic to go out on them and not on the gateway.
I can share the plugin as well if anyone wants it.