Skip to content

README.md: add openssf passing badge #26087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented May 7, 2025

[NO NEW TESTS NEEDED]

Does this PR introduce a user-facing change?

None

[NO NEW TESTS NEEDED]

Signed-off-by: Lokesh Mandvekar <[email protected]>
@openshift-ci openshift-ci bot added release-note-none do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 7, 2025
Copy link
Contributor

openshift-ci bot commented May 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2025
@lsm5
Copy link
Member Author

lsm5 commented May 7, 2025

Do not merge until no-objection from @mtrmac :)

@mtrmac
Copy link
Collaborator

mtrmac commented May 7, 2025

Is that WRT badges in general (as in containers/skopeo#2596 ) or WRT the OpenSSF compliance?

I’m… not inclined to make too much of a fuss about either one, although I think it’s worth a bit of discussion.

@lsm5
Copy link
Member Author

lsm5 commented May 7, 2025

Is that WRT badges in general (as in containers/skopeo#2596 ) or WRT the OpenSSF compliance?

openssf compliance

I’m… not inclined to make too much of a fuss about either one, although I think it’s worth a bit of discussion.

ack, sgtm

@lsm5 lsm5 marked this pull request as ready for review May 8, 2025 10:28
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 8, 2025
@lsm5
Copy link
Member Author

lsm5 commented May 8, 2025

Opening for review.

@TomSweeneyRedHat
Copy link
Member

LGTM
as far as what you meant it to do. I'll leave it up to others to decide if want the badge or not. I'm fine with it.

@mheon
Copy link
Member

mheon commented May 12, 2025

/lgtm

@mheon
Copy link
Member

mheon commented May 12, 2025

Oh
/hold

@mheon
Copy link
Member

mheon commented May 12, 2025

Just saw ther comment about waiting for confirmation from @mtrmac

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels May 12, 2025
@mtrmac
Copy link
Collaborator

mtrmac commented May 12, 2025

I think I’d like at least a record of whether we were looking only at the Podman proper, or also at vendored dependencies. If we are including vendored dependencies, let’s be transparent about that.

More in a different channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants