Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pr_checks.yaml linting #4999

Merged
merged 2 commits into from
Apr 8, 2025

Conversation

uinstinct
Copy link
Contributor

Description

comment out the empty lists in github actions pr_check.yaml config's require-all-checks-to-pass job. so that it becomes a valid config

Checklist

  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screenshots

before

image

after

image

Testing instructions

[ For new or modified features, provide step-by-step testing instructions to validate the intended behavior of the change, including any relevant tests to run. ]

comment out the empty lists in yaml
@uinstinct uinstinct requested a review from a team as a code owner April 5, 2025 06:05
@uinstinct uinstinct requested review from Patrick-Erichsen and removed request for a team April 5, 2025 06:05
Copy link

netlify bot commented Apr 5, 2025

Deploy Preview for continuedev ready!

Name Link
🔨 Latest commit 01d0b4e
🔍 Latest deploy log https://app.netlify.com/sites/continuedev/deploys/67f4b404bf7b3e00089dc052
😎 Deploy Preview https://deploy-preview-4999--continuedev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Patrick-Erichsen
Copy link
Collaborator

Are you sure there isn't some side effect of having those as empty values?

If so, let's just delete them altogether rather than commenting out.

@uinstinct
Copy link
Contributor Author

Are you sure there isn't some side effect of having those as empty values?

If so, let's just delete them altogether rather than commenting out.

yes, there will be no side effects. by default those options are empty arrays.

@Patrick-Erichsen
Copy link
Collaborator

Great, thanks for the followup and for addressing this!

@Patrick-Erichsen Patrick-Erichsen merged commit 272de02 into continuedev:main Apr 8, 2025
29 checks passed
@uinstinct uinstinct deleted the fix-yaml-lint-error branch April 8, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants