feat: remove edit as a mode #5801

Patrick-Erichsen · 2025-05-22T21:46:19Z

Closes CON-1937

Summary by cubic

Removed "edit" as a selectable mode and replaced it with a simpler edit state, streamlining the UI and related logic.

Refactors
- Removed the "edit" mode from mode selection and related UI components.
- Added a new isInEdit state to track when editing is active.
- Updated input, toolbar, and session logic to use isInEdit instead of mode checks.
- Simplified and reorganized edit-related components and thunks.

Screenshots

Edit

Edit outcome

Mode select

Chat/Agent apply actions

Testing instructions

Don't switch between your main editor and your debug editor while testing, it will mess with redux state.

Edit

Type some text into Chat
Highlight code and cmd + I to enter Edit
Prompt, accept, confirm edit behavior and that the original editor content from Chat is restored. Do the same using keyboard shortcut
Prompt, reject, confirm edit behavior and that you're still in Edit. Do the same using keyboard shortcut

Chat/Agent

Send a message that triggers an apply, confirm UI/behavior

netlify · 2025-05-22T21:46:24Z

✅ Deploy Preview for continuedev canceled.

Name	Link
🔨 Latest commit	`3d407ee`
🔍 Latest deploy log	https://app.netlify.com/projects/continuedev/deploys/6833d30dc79ac80008f8c020

Patrick-Erichsen

Lot of code changes here because of file renames/reorg, cleanup of linting errors (eg adding voids), etc

The meat of the logic is the following:

Make edit a boolean instead of a mode
Enhance the lump toolbar, primarily by moving apply states into it
When a user enters edit, clear the editor, but save the previous content and restore it when the user exits Edit

core/index.d.ts

Patrick-Erichsen · 2025-05-23T01:15:13Z

gui/src/components/AcceptRejectDiffButtons.tsx

          <span>Accept</span>
          <span className="xs:inline-block hidden">All</span>
        </div>
-        <span


Removed this because of space constraints on the lump, and moved it into a tooltip

gui/src/components/Layout.tsx

Patrick-Erichsen · 2025-05-23T01:17:21Z

gui/src/components/mainInput/Lump/LumpToolbar.tsx

This was moved into LumpToolbar/ folder where we colocate all the other toolbars

gui/src/components/mainInput/util/index.ts

Patrick-Erichsen · 2025-05-23T01:19:52Z

gui/src/redux/slices/editState.ts

  // Array because of previous multi-file edit functionality
  // Keeping array to not break persisted redux for now
  codeToEdit: SetCodeToEditPayload[];
  applyState: ApplyState;
  returnToMode: MessageModes;
  lastNonEditSessionWasEmpty: boolean;
+  previousModeEditorContent: JSONContent | undefined;


this is how we cache/return the editor content between edits

RomneyDa

One more thing to think about, should we persist isInEdit to redux? Maybe not

gui/src/components/ModeSelect/ModeSelect.tsx

RomneyDa · 2025-05-23T18:30:05Z

gui/src/components/mainInput/Lump/LumpToolbar/LumpToolbar.tsx

+  };
+
+  useEffect(() => {
+    document.addEventListener("keydown", handleKeyDown);


assuming this wasn't changed on this PR but this might cause a bug bc the toolCallState = generated check should be in the use effect adding/removing the listener, not in the listener itself?

gui/src/components/mainInput/TipTapEditor/MainEditorProvider.tsx

continue-code-review · 2025-05-25T15:58:53Z

🚨 Code Review Error

GitHub API error (422): Unprocessable Entity

Please check the logs or contact the maintainers for assistance.

continue-code-review · 2025-05-26T00:40:45Z

🚨 Code Review Error

GitHub API error (422): Unprocessable Entity

Please check the logs or contact the maintainers for assistance.

continue-code-review

📝 Incremental review for latest commit: Found 1 issues in the latest commit

continue-code-review · 2025-05-26T00:48:27Z

gui/src/pages/gui/Chat.tsx

@@ -292,9 +294,11 @@ export function Chat() {

  return (
    <>
-      {!!showSessionTabs && mode !== "edit" && <TabBar ref={tabsRef} />}
+      {!!showSessionTabs && isInEdit && <TabBar ref={tabsRef} />}


The logic change appears inconsistent. The condition changed from mode !== "edit" to isInEdit, which inverts the behavior. This means TabBar with ref will now show when in edit mode instead of when not in edit mode. Please verify this is the intended behavior, as it contradicts the logic on line 300 where !isInEdit is used to show TabBar without ref.

continue-code-review

📝 Incremental review for latest commit: Found 1 issues in the latest commit

gui/src/pages/gui/Chat.tsx

sestinj

Kind of a small thing but I think for people with affected themes it will be pretty bothersome. Is there a foreground theme var that is intended to work with this background var?

continue-code-review · 2025-05-26T02:33:55Z

✅ Latest commit looks good

Patrick-Erichsen · 2025-05-26T02:34:52Z

bg-table-oddRow doesn't feel like the most semantic var but looks good on light/dark

feat: remove edit as a mode

4f371a0

Patrick-Erichsen requested a review from a team as a code owner May 22, 2025 21:46

Patrick-Erichsen requested review from sestinj and removed request for a team May 22, 2025 21:46

github-project-automation bot added this to Issues and PRs May 22, 2025

github-project-automation bot moved this to Todo in Issues and PRs May 22, 2025

dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label May 22, 2025

Patrick-Erichsen added 2 commits May 22, 2025 15:39

fix: navigation bug

fab5347

feat: better editor content handling in edit

7c72c4a

Patrick-Erichsen requested review from RomneyDa and removed request for sestinj May 23, 2025 00:14

Patrick-Erichsen added 3 commits May 22, 2025 17:41

feat: move apply accept/reject into lump

071ecb9

fix: chat tests

7be3bb4

Update MainEditorProvider.tsx

74734e2

Patrick-Erichsen commented May 23, 2025

View reviewed changes

RomneyDa previously approved these changes May 23, 2025

View reviewed changes

github-project-automation bot moved this from Todo to In Progress in Issues and PRs May 23, 2025

dosubot bot added the lgtm This PR has been approved by a maintainer label May 23, 2025

feat: dallins feedback

25b5b8c

Patrick-Erichsen dismissed RomneyDa’s stale review via 25b5b8c May 24, 2025 00:24

sestinj previously approved these changes May 24, 2025

View reviewed changes

Merge branch 'main' into pe/remove-edit-mode

3c77d51

Patrick-Erichsen dismissed sestinj’s stale review via 3c77d51 May 25, 2025 15:58

RomneyDa previously approved these changes May 25, 2025

View reviewed changes

Patrick-Erichsen added 2 commits May 25, 2025 17:39

Merge branch 'main' into pe/remove-edit-mode

3682175

chore: merge main

bbfb126

Patrick-Erichsen dismissed RomneyDa’s stale review via bbfb126 May 26, 2025 00:39

Update Chat.tsx

37e2d81

continue-code-review bot reviewed May 26, 2025

View reviewed changes

Update Chat.tsx

d467745

continue-code-review bot reviewed May 26, 2025

View reviewed changes

gui/src/pages/gui/Chat.tsx Show resolved Hide resolved

sestinj requested changes May 26, 2025

View reviewed changes

dosubot bot removed the lgtm This PR has been approved by a maintainer label May 26, 2025

Update ModeSelect.tsx

3d407ee

sestinj approved these changes May 26, 2025

View reviewed changes

dosubot bot added the lgtm This PR has been approved by a maintainer label May 26, 2025

Patrick-Erichsen merged commit bc4bb89 into main May 26, 2025
35 checks passed

github-project-automation bot moved this from In Progress to Done in Issues and PRs May 26, 2025

Patrick-Erichsen deleted the pe/remove-edit-mode branch May 26, 2025 02:55

github-actions bot locked and limited conversation to collaborators May 26, 2025

feat: remove edit as a mode #5801

feat: remove edit as a mode #5801

Uh oh!

Conversation

Patrick-Erichsen commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by cubic

Screenshots

Edit

Edit outcome

Mode select

Chat/Agent apply actions

Testing instructions

Edit

Chat/Agent

Uh oh!

netlify bot commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for continuedev canceled.

Uh oh!

Patrick-Erichsen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Patrick-Erichsen May 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Patrick-Erichsen May 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Patrick-Erichsen May 23, 2025

Choose a reason for hiding this comment

Uh oh!

RomneyDa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

RomneyDa May 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

continue-code-review bot commented May 25, 2025

Uh oh!

continue-code-review bot commented May 26, 2025

Uh oh!

continue-code-review bot left a comment

Choose a reason for hiding this comment

Uh oh!

continue-code-review bot May 26, 2025

Choose a reason for hiding this comment

Uh oh!

continue-code-review bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sestinj left a comment

Choose a reason for hiding this comment

Uh oh!

continue-code-review bot commented May 26, 2025

Uh oh!

Patrick-Erichsen commented May 26, 2025

Uh oh!

Uh oh!

Uh oh!

Patrick-Erichsen commented May 22, 2025 •

edited

Loading

netlify bot commented May 22, 2025 •

edited

Loading