Skip to content

Theme colors rule and contributing guide section #5802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2025

Conversation

RomneyDa
Copy link
Collaborator

@RomneyDa RomneyDa commented May 22, 2025

Description:

  • A section in Contributing.md explaining theme colors
  • A gui-scoped rule telling models how to use theme colors

Follow up to #5766


Summary by cubic

Added a new section to the contributing guide explaining how to use theme colors, and introduced a rule for using theme colors in GUI components.

@RomneyDa RomneyDa requested a review from a team as a code owner May 22, 2025 22:22
@RomneyDa RomneyDa requested review from Patrick-Erichsen and removed request for a team May 22, 2025 22:22
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label May 22, 2025
Copy link

netlify bot commented May 22, 2025

Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit 6820c33
🔍 Latest deploy log https://app.netlify.com/projects/continuedev/deploys/6830c6980742c6000889e274

Copy link
Collaborator

@Patrick-Erichsen Patrick-Erichsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few nitpicks

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs May 22, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 26, 2025
@Patrick-Erichsen Patrick-Erichsen merged commit c04ea42 into main May 26, 2025
35 checks passed
@Patrick-Erichsen Patrick-Erichsen deleted the dallin/colors-rules branch May 26, 2025 16:26
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs May 26, 2025
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants