Instruction-based tools #5809
Instruction-based tools #5809
Conversation
✅ Deploy Preview for continuedev canceled.
|
![continue-code-review[bot]](https://avatars.githubusercontent.com/in/1318760?s=60&v=4){kind=small}
| @@ -292,9 +293,12 @@ class Bedrock extends BaseLLM { | |||
| const convertedMessages = this._convertMessages(messages); | |||
|
|
|||
| const shouldCacheSystemMessage = | |||
| !!systemMessage && this.cacheBehavior?.cacheSystemMessage || this.completionOptions.promptCaching; | |||
| (!!systemMessage && this.cacheBehavior?.cacheSystemMessage) || | |||
There was a problem hiding this comment.
Using !!options.tools is redundant. Consider using just options.tools since the && operator will short-circuit if options.tools is falsy.
| @@ -49,6 +55,7 @@ export const PROVIDER_TOOL_SUPPORT: Record< | |||
| return true; | |||
| } | |||
| // firworks-ai https://docs.fireworks.ai/guides/function-calling | |||
| // TODO - should be under fireworks provider? | |||
There was a problem hiding this comment.
This comment indicates a potential misplacement of Fireworks AI logic. The code should be moved to a dedicated fireworks provider instead of being embedded in the openai provider logic.
| @@ -156,7 +154,7 @@ function InputToolbar(props: InputToolbarProps) { | |||
| > | |||
| {!props.toolbarOptions?.hideUseCodebase && mode !== "edit" && ( | |||
| <div | |||
| className={`${toolsSupported ? "md:flex" : "int:flex"} hover:underline" hidden transition-colors duration-200`} | |||
| className={`hover:underline" hidden transition-colors duration-200 md:flex`} | |||
There was a problem hiding this comment.
The CSS class string contains a stray quote character and malformed class structure: "hover:underline" hidden transition-colors duration-200 md:flex". This should be cleaned up to remove the extra quotes.
|
|
||
| // Set up completions options with tools | ||
| const completionOptions: LLMFullCompletionOptions = | ||
| useNative && activeTools.length |
There was a problem hiding this comment.
Using ternary operator with empty object fallback could be simplified. Consider using a more explicit conditional assignment for better readability.
Description
Summary by cubic
Added support for non-native tool calls using XML parsing, allowing the app to handle tool calls from models that do not support native tool call APIs.
New Features
Dependencies
fast-xml-parserfor XML parsing in the GUI.