Skip to content

feat: 🧱 Enable terminals for additional vscode Remote Host Types #5813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: 🧱 Enable terminals for additional vscode Remote Host Types #5813

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion core/tools/implementations/runTerminalCommand.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,15 @@ import { isProcessBackgrounded, removeBackgroundedProcess } from "../../util/pro

const asyncExec = util.promisify(childProcess.exec);

const ENABLED_FOR_REMOTES = ["","local","wsl","dev-container","devcontainer","ssh-remote","attached-container","codespaces","tunnel"];

export const runTerminalCommandImpl: ToolImpl = async (args, extras) => {
// Default to waiting for completion if not specified
const waitForCompletion = args.waitForCompletion !== false;
const ideInfo = await extras.ide.getIdeInfo();
const toolCallId = extras.toolCallId || "";

if (ideInfo.remoteName === "local" || ideInfo.remoteName === "") {
if (ENABLED_FOR_REMOTES.includes(ideInfo.remoteName)) {
// For streaming output
if (extras.onPartialOutput) {
return new Promise((resolve, reject) => {
Expand Down
Loading