Skip to content

feat: ✨ Make the terminal command aware of its OS, platform and shell #5814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chezsmithy
Copy link
Contributor

@chezsmithy chezsmithy commented May 23, 2025

Description

  • Made the terminal tool aware of its OS, Platform Arch and default Shell.

Defaults and Observations from testing:

  • Windows - cmd.exe but it also appears to be aware it can use powershell. (we could default to powershell if desired).
  • Linux - bash
  • MacOS - zsh

Checklist

  • I've read the contributing guide
  • The relevant docs, if any, have been updated or created
  • The relevant tests, if any, have been updated or created

Screenshots

[ For visual changes, include screenshots. Screen recordings are particularly helpful, and appreciated! ]

Tests

Peformed manual testing on Windows 11, Linux in WSL and MacOS.
The shell is correctly reported and scripts that are created are optimized for the platform and shell.
It's assumed that the extension is installed on the extension host for the platform. For example on Windows 11, I tested using the extension installed in WSL as a remote extension with VSCode running on windows and the shell is reported as bash, running on Linux.


Summary by cubic

The terminal command tool now detects the current OS, platform architecture, and default shell to optimize commands and scripts. This helps ensure commands run correctly across different environments.

@chezsmithy chezsmithy requested a review from a team as a code owner May 23, 2025 07:47
@chezsmithy chezsmithy requested review from Patrick-Erichsen and removed request for a team May 23, 2025 07:47
Copy link

netlify bot commented May 23, 2025

Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit 1a786f6
🔍 Latest deploy log https://app.netlify.com/projects/continuedev/deploys/6830281389b8760008594444

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

1 participant