Skip to content

Mcp streamable http #5829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

maxxrdrgz
Copy link
Contributor

Description

Added initial implementation for supporting the StreamableHTTP transport from the MCP sdk. It's a pretty simple implementation. I tested this on an Arm Mac. Addresses #5738 and #5790 .

From what I've seen so far, StreamableHTTP looks to be a drop in replacement for SSE and that's more or less what we see here with my PR.

More options may be needed in the MCPConnection.ts. But this is a good starting point that allows for http headers.

Checklist

  • I've read the contributing guide
  • The relevant docs, if any, have been updated or created
  • The relevant tests, if any, have been updated or created

@maxxrdrgz maxxrdrgz requested a review from a team as a code owner May 24, 2025 17:19
@maxxrdrgz maxxrdrgz requested review from RomneyDa and removed request for a team May 24, 2025 17:19
Copy link

cubic-dev-ai bot commented May 24, 2025

Your cubic subscription is currently inactive. Please reactivate your subscription to receive AI reviews and use cubic.

Copy link

netlify bot commented May 24, 2025

Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit 2d2ce42
🔍 Latest deploy log https://app.netlify.com/projects/continuedev/deploys/6832435e7a35400008485ba1

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label May 24, 2025
@chezsmithy
Copy link
Contributor

@maxxrdrgz looks like you might have one test failing. Thanks for getting this PR together.

@maxxrdrgz
Copy link
Contributor Author

@chezsmithy yep. I took a quick look at it this morning and find it a bit confusing. I plan on having another look at it later today. Thanks!

- stdio needs about ~30ms to fully connect now. not 1ms.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants