Nate/vllm-no-fim #5833
Merged
Nate/vllm-no-fim #5833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your cubic subscription is currently inactive. Please reactivate your subscription to receive AI reviews and use cubic. |
✅ Deploy Preview for continuedev canceled.
|
dosubot
bot
added
the
size:XL
Patrick-Erichsen
previously approved these changes
May 24, 2025
core/llm/toolSupport.ts
Outdated
|
|
||
| export const PROVIDER_TOOL_SUPPORT: Record<string, (model: string) => boolean> = | ||
| { | ||
| "continue-proxy": (model) => { |
There was a problem hiding this comment.
All this logic is quite difficult to follow
dosubot
bot
added
size:M
|
🚨 Code Review Error GitHub API error (422): Unprocessable Entity Please check the logs or contact the maintainers for assistance. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
vllm doesn't support fim, and shouldn't through the proxy
Checklist
Tests
A test suite was added to check the supportsFim method for many ILLM classes