Skip to content

Update dify.yaml #5320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: next
Choose a base branch
from
Open

Update dify.yaml #5320

wants to merge 3 commits into from

Conversation

ebertti
Copy link

@ebertti ebertti commented Mar 11, 2025

update for last version of dify docker-compose version, with plugin deamon, fix nginx routes, fix plugin deamon envirioments

Changes

Issues

update for last version of dify docker-compose version, with plugin deamon, fix nginx routes, fix plugin deamon envirioments
Copy link

gitguardian bot commented Mar 11, 2025

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - Generic Password edd8f29 templates/compose/dify.yaml View secret
- - Generic Password edd8f29 templates/compose/dify.yaml View secret
- - Generic Password edd8f29 templates/compose/dify.yaml View secret
- - Generic Password edd8f29 templates/compose/dify.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@andrasbacsai
Copy link
Member

update for last version of dify docker-compose version, with plugin deamon, fix nginx routes, fix plugin deamon envirioments

Changes

Issues

Thanks for the PR! I found some issues, could you please check them?

  • What is this API key? I hope it's not an actual one ${PLUGIN_DIFY_INNER_API_KEY:-QaHbTe77CtuXmsfyhR7+vRjI/+XbV1AaFy691iy+kGDv2Jvy0/eAh8Y1}
  • I saw that you removed some auto-generated passwords and users. Why? the ones with the starting with SERVICE_. For example, for Redis.

@andrasbacsai andrasbacsai self-assigned this Mar 18, 2025
@andrasbacsai andrasbacsai added the 💤 Waiting for changes PRs awaiting changes from the author. label Mar 18, 2025
@ebertti
Copy link
Author

ebertti commented Mar 18, 2025

Hi!

Responding to your questions:

What is this API key? I hope it's not an actual one ${PLUGIN_DIFY_INNER_API_KEY:-QaHbTe77CtuXmsfyhR7+vRjI/+XbV1AaFy691iy+kGDv2Jvy0/eAh8Y1}

This is just a default value, but I replace it in a new commit.

Original docker-compose: https://github.com/langgenius/dify/blob/main/docker/docker-compose.yaml

I saw that you removed some auto-generated passwords and users. Why? The ones starting with SERVICE_, for example, for Redis.

I removed them because the worker was connecting without a password, only with an empty one. Since this is an internal network, I believe it shouldn't be a big issue.

@peaklabs-dev
Copy link
Member

Please do not remove the generated variables, as they create default passwords, users... , so they should be kept if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💤 Waiting for changes PRs awaiting changes from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants