Skip to content

small changes for publish on google play #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

small changes for publish on google play #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion App.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ Notifications.setNotificationHandler({

const baseUrl = () => {
console.log('extra.baseUrl =', Constants.expoConfig.extra.baseUrl);
return Constants.expoConfig.extra.baseUrl || "https://staging.timeoverflow.org";
return Constants.expoConfig.extra.baseUrl || "https://www.timeoverflow.org";
Copy link
Collaborator

@sauloperez sauloperez Dec 14, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed this baseUrl in #15. That is how it was supposed to work.

};

export default function App() {
Expand Down
2 changes: 1 addition & 1 deletion app.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"android": {
"googleServicesFile": "./google-services.json",
"package": "org.timeoverflow.mobileapp",
"versionCode": 20
"versionCode": 22
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we could get Expo to this increment for us if we specified "autoIncrement": true in the production profile in eas.json. See remote version source on https://docs.expo.dev/build-reference/app-versions/.

I'm not meaning to do it here, but it's some worth exploring soon. This version bump is to me the biggest bottleneck to publish versions and automate the process.

},
"extra": {
"eas": {
Expand Down
1 change: 1 addition & 0 deletions eas.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
}
},
"production": {
"distribution": "internal",
Copy link
Collaborator

@sauloperez sauloperez Dec 14, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not the intended use of "internal distribution". According to https://docs.expo.dev/build/internal-distribution/:

Uploading your app to TestFlight and Google Play beta can be time-consuming (...) and limiting (...). Both Android and iOS provide alternative mechanisms to distribute apps directly to testers, so they can download and install them to physical devices directly from a web browser as soon as the builds are completed.

EAS Build can help you with this by providing shareable URLs for your builds with instructions on how to get them running, so you can share a single URL with a teammate that'll include all of the information they need to test the app. Interestingly, the example they use is of a preview profile, nothing related to production.

There's an alternative and more explicit way to generate an APK. Taken https://docs.expo.dev/build-reference/apk/#configuring-a-profile-to-build-apks, we can add the following in this production profile. That's I would prefer here.

"android": {
   "buildType": "apk"
}

For the record, from https://docs.expo.dev/build/automating-submissions/, it seems that the process is rather meant to be handled automatically by using the --auto-submit flag. We're not there yet tough. I wouldn't spend time making it work now.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to work on this later on. https://docs.expo.dev/build/eas-json/#production-builds is pretty explicit on how this should be done:

Production builds must be installed through their respective app stores; they cannot be installed directly on your Android Emulator or device, or iOS Simulator or device. The only exception to this is if you explicitly set "buildType": "apk" for Android on your build profile; however, it is recommended to use AAB when submitting to stores, and this is the default configuration.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the record, I solved this using buildType in #15.

"channel": "production",
"env": {
"BASE_URL": "https://www.timeoverflow.org"
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"web": "expo start --web"
},
"dependencies": {
"expo": "~46.0.9",
"expo": "^47.0.8",
"expo-device": "~4.3.0",
"expo-notifications": "~0.16.1",
"expo-status-bar": "~1.4.0",
Expand Down