Skip to content

Identify create virtual table sqlite statements #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/parser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -854,9 +854,11 @@ function stateMachineStatementParser(
return;
}

// Table/View modifiers
if (
['psql', 'sqlite'].includes(dialect) &&
['TEMP', 'TEMPORARY'].includes(token.value.toUpperCase())
(dialect === 'psql' && ['TEMP', 'TEMPORARY'].includes(token.value.toUpperCase())) ||
(dialect === 'sqlite' &&
['TEMP', 'TEMPORARY', 'VIRTUAL'].includes(token.value.toUpperCase()))
) {
setPrevToken(token);
return;
Expand Down
128 changes: 128 additions & 0 deletions test/parser/single-statements.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,134 @@ describe('parser', () => {
expect(actual).to.eql(expected);
});

['TEMP', 'TEMPORARY'].forEach((type) => {
describe(`it should parse "CREATE ${type} TABLE" statement`, () => {
['psql', 'sqlite'].forEach((dialect) => {
it(`for ${dialect}`, () => {
const actual = parse(
`CREATE ${type} TABLE Persons (PersonID int, Name varchar(255));`,
true,
dialect as 'psql' | 'sqlite',
);

actual.tokens = aggregateUnknownTokens(actual.tokens);

const expected = {
type: 'QUERY',
start: 0,
end: 54 + type.length + 1,
body: [
// nodes
{
start: 0,
end: 54 + type.length + 1,
type: 'CREATE_TABLE',
executionType: 'MODIFICATION',
endStatement: ';',
parameters: [],
},
],
tokens: [
{
type: 'keyword',
value: 'CREATE',
start: 0,
end: 5,
},
{
type: 'unknown',
value: ` ${type} `,
start: 6,
end: 6 + type.length + 1,
},
{
type: 'keyword',
value: 'TABLE',
start: 6 + type.length + 2,
end: 6 + type.length + 1 + 5,
},
{
type: 'unknown',
value: ' Persons (PersonID int, Name varchar(255))',
start: 6 + type.length + 1 + 5 + 1,
end: 6 + type.length + 1 + 5 + 42,
},
{
type: 'semicolon',
value: ';',
start: 6 + type.length + 1 + 5 + 42 + 1,
end: 6 + type.length + 1 + 5 + 42 + 1,
},
],
};

expect(actual).to.eql(expected);
});
});
});
});

it('should parse "CREATE VIRTUAL TABLE" statement for sqlite', () => {
const actual = parse(
`CREATE VIRTUAL TABLE Persons (PersonID int, Name varchar(255));`,
true,
'sqlite',
);

actual.tokens = aggregateUnknownTokens(actual.tokens);

const expected = {
type: 'QUERY',
start: 0,
end: 62,
body: [
// nodes
{
start: 0,
end: 62,
type: 'CREATE_TABLE',
executionType: 'MODIFICATION',
endStatement: ';',
parameters: [],
},
],
tokens: [
{
type: 'keyword',
value: 'CREATE',
start: 0,
end: 5,
},
{
type: 'unknown',
value: ` VIRTUAL `,
start: 6,
end: 14,
},
{
type: 'keyword',
value: 'TABLE',
start: 15,
end: 19,
},
{
type: 'unknown',
value: ' Persons (PersonID int, Name varchar(255))',
start: 20,
end: 61,
},
{
type: 'semicolon',
value: ';',
start: 62,
end: 62,
},
],
};

expect(actual).to.eql(expected);
});

it('should parse "CREATE DATABASE" statement', () => {
const actual = parse('CREATE DATABASE Profile;');
actual.tokens = aggregateUnknownTokens(actual.tokens);
Expand Down