feat: Add an IN query to the SQL statement #290
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4tx
requested changes
May 15, 2025
There was a problem hiding this comment.
Hi! Thanks for the contribution and sorry for the massive delay in my response—I lost this in my email queue somehow.
The change seems to be missing the code that actually parses the "in" keyword in the query! macro (this should be added to the parsing code in expr.rs) and some unit tests—right now it doesn't seem to work.
Also, another question is whether we actually want to implement the change with the proposed syntax: perhaps instead of $field in (1, 2, 3) we might want [1, 2, 3].contains($field)? First one is obviously more similar to the SQL generated, but we generally prefer to have more Rusty syntax for the queries. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Add an IN query to the SQL statement