Skip to content

[WIP]Move FormField's custom option validation to field construction #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

[WIP]Move FormField's custom option validation to field construction #304

wants to merge 5 commits into from

Conversation

ElijahAhianyo
Copy link
Contributor

@ElijahAhianyo ElijahAhianyo commented Apr 29, 2025 •
edited
Loading

fixes #294

@github-actions github-actions bot added the C-lib Crate: cot (main library crate) label Apr 29, 2025
@ElijahAhianyo ElijahAhianyo changed the title [WIP]Move OptionField validation to Option Initialization [WIP]Move custom Option field validation to Option Initialization Apr 29, 2025
@ElijahAhianyo ElijahAhianyo changed the title [WIP]Move custom Option field validation to Option Initialization [WIP]Move FormField's custom option validation to field construction Apr 29, 2025
@ElijahAhianyo ElijahAhianyo mentioned this pull request Apr 29, 2025
Open
@codecov Codecov
Copy link

codecov bot commented Apr 29, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.14286% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cot/src/form/fields.rs 97.14% 1 Missing ⚠️
Flag Coverage Δ
rust 85.11% <97.14%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cot/src/form/fields.rs 78.45% <97.14%> (-0.12%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C-lib Crate: cot (main library crate)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Form fields' custom options should be validated when constructing the field
1 participant
@ElijahAhianyo