Skip to content

External prover #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

External prover #3

wants to merge 17 commits into from

Conversation

DougAnderson444
Copy link
Contributor

@DougAnderson444 DougAnderson444 commented Feb 14, 2025 •
edited
Loading

This PR introduces an external prover:

  • minor version bump to 1.1.0 due to breaking change
  • remove passing in the owned key
  • method try_build() now takes a user defined closure to take the cid and generate proof bytes
pub fn try_build(
        &self,
        mut gen_proof: impl FnMut(&Cid) -> Result<Vec<u8>, Error>,
    ) -> Result<Vlad, Error>

Fixes: #2

@DougAnderson444
Copy link
Contributor Author

@dhuseby with the upstream fixes done in #2 this should be ready for another glance

@dhuseby
Copy link
Member

dhuseby commented Mar 21, 2025

Do you still need to change the default dependency on your implementation of multikey and multisig?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

move signing to external wallet
2 participants
@DougAnderson444 @dhuseby