-
Notifications
You must be signed in to change notification settings - Fork 40
adding appimage guide #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
adding appimage guide #80
Conversation
WalkthroughA new manual guide has been introduced that provides step-by-step instructions for building a Cryptomator AppImage from source. The documentation outlines all necessary prerequisites, including the installation of Maven, squashfs-tools, unzip, curl, and JDK 23. It details the process for downloading and preparing the AppImage tool, cloning the Cryptomator repository, and building the project using Maven with the Linux profile. The guide includes optional instructions for testing the generated JAR file with specific system properties. It describes how to set up the required AppImage folder structure, including the placement of the AppRun script, .desktop file, application icon, and the usr directory with its subdirectories. The documentation provides an example AppRun script for launching the application and explains how to finalize the AppImage build using the appimagetool. No changes were made to exported or public code entities; only new documentation was added. Additionally, the main documentation index was updated to include this new guide in the Desktop section's toctree. Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (4)
source/desktop/creating-app-image.rst (4)
1-2
: Ensure heading underline matches title length.
The underline should be exactly as long as the title text to adhere to reStructuredText conventions and avoid potential rendering inconsistencies.
45-52
: Normalize nested list indentation.
To ensure the bullet list under step 2 renders correctly, indent sub-items consistently (e.g., 3–4 spaces) relative to the parent list. For example:2. Inside it, place: - ``AppRun`` (see below) - A ``.desktop`` file - App icon (``.png``) - A ``usr/`` folder
86-86
: Add example.desktop
entry.
Consider including a minimal.desktop
file snippet (withName=
,Exec=AppRun
,Icon=...
,Type=Application
) so users can copy/paste and adapt.
98-99
: Ensure newline at end of file.
Add a trailing newline (EOF newline) to comply with POSIX text file standards and avoid potential tools warnings.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/desktop/creating-app-image.rst
(1 hunks)
🔇 Additional comments (3)
source/desktop/creating-app-image.rst (3)
1-99
: Well-structured and comprehensive guide.
The documentation provides clear, step-by-step instructions covering prerequisites, setup, testing, and building an AppImage for Cryptomator. Great work on the overall organization and clarity!
7-7
: Clarify JDK requirement and reference official docs.
Confirm whether JDK 23 is strictly required or if Java 11+ suffices. Consider linking to the official Cryptomator documentation or release notes for the exact Java version requirement.
1-99
: Verify inclusion in Sphinx ToC.
Since this is a new documentation file, ensure it’s added to the Sphinxtoctree
(e.g., inindex.rst
) so it appears in the published documentation.
No description provided.