fix(F*): rename instance ids, following cryspen/hax#1391 #916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we open an issue, if none exists, that we need to find a way to address instances in annotations, and then link that issue here? |
|
I filed cryspen/hax#1398 :) |
franziskuskiefer
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates some (hardcoded, we have no better way currently, see cryspen/hax#1398) instance identifiers.
Those changed because of cryspen/hax#1391 which is updating the rustc pin: instance identifiers are hashes, so subtle changes to the AST make them change.
Note: th failure of hax-related jobs here is expected. I will bypass hax CI to get cryspen/hax#1391 in, then we will merge that PR.
I'm waiting on your approval @franziskuskiefer to bypass hax CI on cryspen/hax#1391, so that we can merge this PR right after.