Skip to content

[CW2-36] Linking Merch Store Link in nav bar and hamburger #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 1, 2024
Merged

[CW2-36] Linking Merch Store Link in nav bar and hamburger #24

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b8d4351
Adding Merch Store Link to nav bar and hamburger
Jul 11, 2024
5adfbe9
Adding suggested changes
Jul 18, 2024
a2dbfd4
Making hamburger link open in seperate tab
Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions frontend/public/assets/merch-store-icon.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions frontend/src/components/Hamburger.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@ export default function Hamburger() {
<li className="py-2 text-lg">
<Link href={'./contact-us'}>Contact Us</Link>
</li>
<li className="py-2 text-lg">
<a href="https://csesoc-merch.square.site/">Merchandise</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe call this merch store

</li>
</ul>
</motion.div>
)}
Expand Down
10 changes: 10 additions & 0 deletions frontend/src/components/Navbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,16 @@ const Navbar = () => {
<Link href="/contact-us">
<div className="text-xl">{'//'} contact us</div>
</Link>
<a href="https://csesoc-merch.square.site/" className='flex xl:gap-3 lg:gap-1.5 md:gap-0.8 duration-300 hover:scale-105'>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just get rid of the text and just have the icon, otherwise it's too much

Also, maybe make it so that the link opens in a new tab

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also thinking about it now, I think from experience navbars generally don't really have animations? Idk, just my opinion

<div className="text-xl">{'//'} merch store</div>
<Image
src="/assets/merch-store-icon.svg"
alt="Merchandise Store Icon"
width={30}
height={30}
draggable={false}
/>
</a>
</div>
<div className="md:hidden xl:hidden lg:hidden text-right font-bold block">
<Hamburger />
Expand Down
Loading