Skip to content

Cw2-18 Improve Semantic HTML #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 18, 2024
Merged

Cw2-18 Improve Semantic HTML #7

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
34e4d8a
changed the h1 tags
QuadAces Apr 11, 2024
87ff724
changed image alt tags
QuadAces Apr 11, 2024
1d71453
changed tailwind
QuadAces Apr 11, 2024
3fa4d93
CW2-3 Add events section (#4)
QuadAces Apr 12, 2024
086d491
changes to make linter approve
QuadAces Apr 17, 2024
00988b0
Merge branch 'CW2-18_Improve_Semantic_HTML' of https://github.com/cse…
QuadAces Apr 17, 2024
88f5c89
formatted code?
QuadAces Apr 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions components/About/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const About = () => {
<section className="py-8 xl:px-24 sm:px-10 px-5" id="about">
<div className="text-center my-10">
<p className="text-[#3977F8] font-game text-xl">01</p>
<h1 className="font-bold text-6xl">ABOUT</h1>
<h2 className="font-bold text-6xl">ABOUT</h2>
</div>
<div className="flex justify-center items-center">
<div className="lg:grid grid-cols-6 flex-1 max-w-[90rem]">
Expand All @@ -14,7 +14,7 @@ const About = () => {
<div className="flex items-center justify-center">
<Image src="/assets/csesoc_icon.svg" alt="CSESoc Icon" width={150} height={150} />
</div>
<h1 className="mt-10 text-3xl font-extrabold">CSESoc</h1>
<h2 className="mt-10 text-3xl font-extrabold">CSESoc</h2>
<p className="text-[#727B8C] font-medium">unsw-computer-science-soc</p>
<button className="bg-[#444F6F] w-full my-5 py-2 rounded">Follow</button>
<p>
Expand All @@ -40,7 +40,7 @@ const About = () => {
</div>
{/* RIGHT SIDE */}
<div className="col-span-4 lg:mt-0 mt-10">
<div className="rounded border border-[#595F6D] p-5 2xl:h-80 xl:h-64 lg:h-48 sm:h-36 h-32 h-full">
<div className="rounded border border-[#595F6D] p-5 2xl:h-80 xl:h-64 lg:h-48 sm:h-36 h-full">
<p className="text-xs">
csesoc/README<span className="text-[#7A8192]">.md</span>
</p>
Expand Down
2 changes: 1 addition & 1 deletion components/Landing/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const Landing = () => {
<div>
<div className="font-semibold">
<p>{'<h1>'}</p>
<h1 className="font-black 2xl:text-8xl lg:text-6xl text-4xl">Hello World!</h1>
<h2 className="font-black 2xl:text-8xl lg:text-6xl text-4xl">Hello World!</h2>
<p>{'</h1>'}</p>
</div>
<div className="font-semibold mt-10">
Expand Down
8 changes: 4 additions & 4 deletions components/ResourcesAndContacts/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

<div className="text-center my-10">
<p className="text-[#3977F8] font-game text-xl">03</p>
<h1 className="font-bold text-6xl">RESOURCES & CONTACTS</h1>
<h2 className="font-bold text-6xl">RESOURCES & CONTACTS</h2>
</div>

<div className="py-8 bg-no-repeat bg-center">
Expand Down Expand Up @@ -122,23 +122,23 @@
<div className="md:mt-10 mt-5">
<div className="grid grid-cols-3 1 gap-x-9 gap-y-5 mb-10">
<a href="https://bit.ly/CSESocDiscord" target="_blank" className={socialsBoxStyling}>
<Image src="assets/discord_logo.svg" alt="" width={25} height={25} className="mr-1" />
<Image src="assets/discord_logo.svg" alt="discord logo" width={25} height={25} className="mr-1" />

Check failure on line 125 in components/ResourcesAndContacts/index.tsx

View workflow job for this annotation

GitHub Actions / build 

Replace `·src="assets/discord_logo.svg"·alt="discord·logo"·width={25}·height={25}·className="mr-1"` with `⏎················src="assets/discord_logo.svg"⏎················alt="discord·logo"⏎················width={25}⏎················height={25}⏎················className="mr-1"⏎·············`
<p className="text-xl font-bold m-2">DISCORD</p>
</a>
<a
href="https://www.facebook.com/csesoc/"
target="_blank"
className={socialsBoxStyling}
>
<Image src="assets/fb_logo.svg" alt="" width={25} height={25} className="mr-1" />
<Image src="assets/fb_logo.svg" alt="facebook logo" width={25} height={25} className="mr-1" />

Check failure on line 133 in components/ResourcesAndContacts/index.tsx

View workflow job for this annotation

GitHub Actions / build 

Replace `·src="assets/fb_logo.svg"·alt="facebook·logo"·width={25}·height={25}·className="mr-1"` with `⏎················src="assets/fb_logo.svg"⏎················alt="facebook·logo"⏎················width={25}⏎················height={25}⏎················className="mr-1"⏎·············`
<p className="text-xl font-bold m-2">FACEBOOK</p>
</a>
<a
href="https://www.facebook.com/groups/csesoc"
target="_blank"
className={socialsBoxStyling}
>
<Image src="assets/group_icon.svg" alt="" width={25} height={25} className="mr-1" />
<Image src="assets/group_icon.svg" alt="facebook group" width={25} height={25} className="mr-1" />

Check failure on line 141 in components/ResourcesAndContacts/index.tsx

View workflow job for this annotation

GitHub Actions / build 

Replace `·src="assets/group_icon.svg"·alt="facebook·group"·width={25}·height={25}·className="mr-1"` with `⏎················src="assets/group_icon.svg"⏎················alt="facebook·group"⏎················width={25}⏎················height={25}⏎················className="mr-1"⏎·············`
<p className="text-xl font-bold m-2">FACEBOOK GROUP</p>
</a>
</div>
Expand Down
Loading