Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pylint: modernize the run-pylint.sh script #198

Merged
merged 1 commit into from
Apr 7, 2025
Merged

Conversation

kdudka
Copy link
Member

@kdudka kdudka commented Apr 4, 2025

... to make it work the same way as run-shellcheck.sh works now.

Given the fact that pylint is not enabled by default, the run-pylint.sh script has not been actively maintained. This commit transfers the well-tested parts of code from run-shellcheck.sh to run-pylint.sh.

@kdudka kdudka requested review from siteshwar and jamacku April 4, 2025 11:13
@kdudka kdudka self-assigned this Apr 4, 2025
kdudka added a commit to kdudka/csmock that referenced this pull request Apr 4, 2025
... to make it work the same way as `run-shellcheck.sh` works now.

Given the fact that `pylint` is not enabled by default, the
`run-pylint.sh` script has not been actively maintained.  This commit
transfers the well-tested parts of code from `run-shellcheck.sh` to
`run-pylint.sh`.

Closes: csutils#198
Copy link
Member

@jamacku jamacku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kdudka
Copy link
Member Author

kdudka commented Apr 4, 2025

/packit rebuild-failed

@kdudka
Copy link
Member Author

kdudka commented Apr 4, 2025

@jamacku Thanks for review! I have reported the SC2317 false positives as koalaman/shellcheck#3183.

... to make it work the same way as `run-shellcheck.sh` works now.

Given the fact that `pylint` is not enabled by default, the
`run-pylint.sh` script has not been actively maintained.  This commit
transfers the well-tested parts of code from `run-shellcheck.sh` to
`run-pylint.sh`.

Closes: csutils#198
@kdudka
Copy link
Member Author

kdudka commented Apr 5, 2025

/packit rebuild-failed

1 similar comment
@jamacku
Copy link
Member

jamacku commented Apr 6, 2025

/packit rebuild-failed

@kdudka
Copy link
Member Author

kdudka commented Apr 7, 2025

Thank you both for review!

@kdudka kdudka merged commit 43f6ab4 into csutils:main Apr 7, 2025
44 checks passed
@kdudka kdudka deleted the run-pylint branch April 7, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants