-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pylint: modernize the run-pylint.sh
script
#198
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdudka
added a commit
to kdudka/csmock
that referenced
this pull request
Apr 4, 2025
... to make it work the same way as `run-shellcheck.sh` works now. Given the fact that `pylint` is not enabled by default, the `run-pylint.sh` script has not been actively maintained. This commit transfers the well-tested parts of code from `run-shellcheck.sh` to `run-pylint.sh`. Closes: csutils#198
jamacku
approved these changes
Apr 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
/packit rebuild-failed |
@jamacku Thanks for review! I have reported the |
... to make it work the same way as `run-shellcheck.sh` works now. Given the fact that `pylint` is not enabled by default, the `run-pylint.sh` script has not been actively maintained. This commit transfers the well-tested parts of code from `run-shellcheck.sh` to `run-pylint.sh`. Closes: csutils#198
/packit rebuild-failed |
1 similar comment
/packit rebuild-failed |
siteshwar
approved these changes
Apr 7, 2025
Thank you both for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to make it work the same way as
run-shellcheck.sh
works now.Given the fact that
pylint
is not enabled by default, therun-pylint.sh
script has not been actively maintained. This commit transfers the well-tested parts of code fromrun-shellcheck.sh
torun-pylint.sh
.