Skip to content

feat(cubesql): Support for metabase literal queries #4843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 3, 2022

Conversation

paveltiunov
Copy link
Member

@paveltiunov paveltiunov commented Jul 3, 2022

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

#3906

@paveltiunov paveltiunov requested review from a team as code owners July 3, 2022 00:09
@codecov
Copy link

codecov bot commented Jul 3, 2022

Codecov Report

Merging #4843 (0478b48) into master (f59b0d7) will decrease coverage by 8.91%.
The diff coverage is 74.28%.

@@            Coverage Diff             @@
##           master    #4843      +/-   ##
==========================================
- Coverage   81.51%   72.60%   -8.92%     
==========================================
  Files         120      256     +136     
  Lines       16854    28041   +11187     
  Branches        0     2782    +2782     
==========================================
+ Hits        13739    20358    +6619     
- Misses       3115     7178    +4063     
- Partials        0      505     +505     
Flag Coverage Δ
cube-backend 59.14% <ø> (?)
cubesql 81.53% <74.28%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/cubesql/cubesql/src/compile/engine/df/scan.rs 74.48% <52.94%> (-2.24%) ⬇️
rust/cubesql/cubesql/src/compile/mod.rs 77.35% <88.00%> (+0.02%) ⬆️
...besql/cubesql/src/compile/rewrite/rules/members.rs 98.00% <95.45%> (-0.09%) ⬇️
...t/cubesql/cubesql/src/compile/rewrite/converter.rs 92.00% <100.00%> (+0.20%) ⬆️
rust/cubesql/cubesql/src/compile/rewrite/cost.rs 96.66% <100.00%> (+0.05%) ⬆️
rust/cubesql/cubesql/src/compile/rewrite/mod.rs 92.16% <100.00%> (+0.05%) ⬆️
rust/cubesql/cubesql/src/sql/dataframe.rs 68.09% <100.00%> (-0.31%) ⬇️
rust/cubesql/cubesql/src/sql/mysql/service.rs 53.99% <100.00%> (ø)
rust/cubesql/cubesql/src/sql/postgres/extended.rs 90.09% <100.00%> (ø)
rust/cubesql/cubesql/src/sql/postgres/shim.rs 61.91% <0.00%> (-0.20%) ⬇️
... and 137 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f59b0d7...0478b48. Read the comment docs.

@paveltiunov paveltiunov merged commit 6d45d55 into master Jul 3, 2022
@paveltiunov paveltiunov deleted the literal-member-support branch July 3, 2022 02:10
@rpaik rpaik added the Roadmap: 2022 Q2 Cube roadmap for Q2 of 2022 label Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Roadmap: 2022 Q2 Cube roadmap for Q2 of 2022
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants