bugfix: Fix potential NME when converting ParameterType to envelope #1789
Conversation
|
@luke-hill relatively straight-forward fix, although I'm not super pleased with the rspec test due to the method of interest being private. I don't think this warrants an update to any of the features since it's an admittedly weird way to declare a |
| @@ -30,6 +30,7 @@ refactored to use newer, less procedural ruby_) | |||
| - Fixed an issue where a change to one example in compatibility testing wasn't fully adhered to ([luke-hill](https://github.com/luke-hill)) | |||
| - Fixed Ruby 3.4+ issue where error backtraces weren't being formatted. ([#1771](https://github.com/cucumber/cucumber-ruby/pull/1771) [orien](https://github.com/orien)) | |||
| - Fix some problematic specs that were leaking state and showcasing an issue on JRuby ([#1783](https://github.com/cucumber/cucumber-ruby/pull/1783) [luke-hill](https://github.com/luke-hill)) | |||
| - Fixed an issue where NoMethodError could be raised when declaring a parameter-type that used bound methods ([#1789](https://github.com/cucumber/cucumber-ruby/pull/1789)) | |||
There was a problem hiding this comment.
This will conflict soon as I'm about to cut v10. I will happily cut another v10.0.1 soon after if desired
| def source_reference_for(transformer) | ||
| # #source_location may return nil if no definition was found | ||
| # This is the case for transformers created using method(sym) or similar | ||
| return nil if transformer.source_location.nil? |
There was a problem hiding this comment.
Not 100% we can do this as it might break the contract we have in messages.
There was a problem hiding this comment.
My understanding is that the sourceReference field for ParameterType has always been optional:
- cucumber-messages @ v22.0.0 -- first introduced here
- cucumber-messages @ v27.2.0 -- current HEAD
This is why I opted specifically to omit the entire SourceReference object, rather than providing one with nil interior values
| let(:prefer_for_regexp_match) { true } | ||
|
|
||
| before do | ||
| allow(configuration).to receive_message_chain(:id_generator, :new_id).and_return(id) # rubocop:disable RSpec/MessageChain |
There was a problem hiding this comment.
I'm trying to remove inline stuff, I don't mind it being added to the overall directive to be fixed up at a later date or if you can tackle it here that would be good
| regular_expressions: [%("[^"]+")], | ||
| prefer_for_regular_expression_match: true, | ||
| use_for_snippets: false, | ||
| source_reference: anything # tested in later cases |
There was a problem hiding this comment.
To avoid cop offenses can this be returned as something like :no_op
Description
Sets
source_referencetonilif the parameter type transformer does not provide a valid source location, i.e. isnil.Fixes #1788
Type of change
Bug fix (non-breaking change which fixes an issue)
Checklist:
Your PR is ready for review once the following checklist is
complete. You can also add some checks if you want to.
bundle exec rubocopreports no offenses