Skip to content

Export components and hooks at root #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 5, 2025
Merged

Export components and hooks at root #383

merged 4 commits into from
May 5, 2025

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented May 5, 2025

🤔 What's changed?

Components and hooks are now exported in a "flat" manner on the main entry point. Previously we exported components and hooks symbols which were objects containing components or hooks one or two levels deep.

⚡️ What's your motivation?

There was no real need to do this, since there are no naming collisions with any of the exported members. It also made the library harder to work with as a consumer, since editors tend not to work well with that non-standard way of exporting for auto-import etc.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)
  • 💥 Breaking change (incompatible changes to the API)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

Copy link

netlify bot commented May 5, 2025

Deploy Preview for cucumber-react-preview ready!

Name Link
🔨 Latest commit 4ed9ff6
🔍 Latest deploy log https://app.netlify.com/sites/cucumber-react-preview/deploys/6818987ebb7a050008ec1e83
😎 Deploy Preview https://deploy-preview-383--cucumber-react-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@davidjgoss davidjgoss marked this pull request as ready for review May 5, 2025 10:54
@davidjgoss davidjgoss merged commit 58d5417 into main May 5, 2025
6 checks passed
@davidjgoss davidjgoss deleted the clean-up-exports branch May 5, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant