-
-
Notifications
You must be signed in to change notification settings - Fork 476
Repairing pywin32 example (#224) #374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repairing pywin32 example (#224) #374
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default there is a random port generated:
https://github.com/cztomczak/cefpython/blob/master/api/ApplicationSettings.md#remote_debugging_port
Thanks for the PR. Code changes are overall good, there are only some minor style issues. I will test it when I switch to a Windows machine. |
Yes you can remove this commit, it was for my personals tests, I should not have added that to this branch... |
Related issue: Issue #224 ("Port CEF 1 examples to CEF 3"). |
I have tested on Windows 7 with Python 2.7/3.4 and it works fine in default loop mode. However in multi threaded message loop it crashes on exit. Have you noticed this behavior during your testing? |
Yes, and it was something I wanted to bring to your attention, but I forgot :/ |
That makes sense. Created Issue #380 to fix that. |
Thanks. I will make additional changes to the example in a separate commit. |
Add link to README-examples. Add usage comments. Fix code style issues - get rid of PEP8 and PyCharm notices/warnings. Load chromium.ico icon.
Additional changes in commit b9875f5. |
@jf-mgd If you would like to add add yourself to the Authors file then please send a separate PR for that. In the authors file you can add and email or a website link next to your name. |
No description provided.