Skip to content

[dg] Better logging message for asset check evals #29048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

schrockn
Copy link
Member

@schrockn schrockn commented Apr 6, 2025

Summary & Motivation

Noticed this while preparing a demo. Improve the logging for asset check evaluations to actually include if they passed or not.

How I Tested These Changes

2025-04-06 16:56:11 -0400 - dagster - DEBUG - __ASSET_JOB - 5eddbb3a-1dbc-4b72-b033-53069b2483e5 - 48173 - orders_min_user_id_test - STEP_INPUT - Got input "df" of type "DataFrame". (Type check passed).
2025-04-06 16:56:11 -0400 - dagster - DEBUG - __ASSET_JOB - 5eddbb3a-1dbc-4b72-b033-53069b2483e5 - 48173 - orders_min_user_id_test - ASSET_CHECK_EVALUATION - Asset check 'min_user_id_test' on 'orders' did not pass. Description: 'Minimum value of 1000 not met for column user_id. Found 1'
2025-04-06 16:56:11 -0400 - dagster - DEBUG - __ASSET_JOB - 5eddbb3a-1dbc-4b72-b033-53069b2483e5 - 48173 - orders_min_user_id_test - STEP_OUTPUT - Yielded output "result" of type "Any". (Type check passed).

Changelog

  • Improved logging message on asset checks.

Copy link
Member Author

schrockn commented Apr 6, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@schrockn schrockn requested review from dpeng817 and OwenKephart April 6, 2025 22:25
@schrockn schrockn marked this pull request as ready for review April 6, 2025 22:25
@schrockn schrockn requested review from benpankow and gibsondan April 7, 2025 17:14
Copy link
Member

@gibsondan gibsondan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's also severity?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants