[dg] Rename PackageObject* -> PluginObject* #29080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
smackesey
force-pushed
the
sean/dg/package-object-renames
branch
from
232a875 to
752f9c4
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
|
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-3rivfvshs-elementl.vercel.app Direct link to changed pages: |
smackesey
force-pushed
the
sean/dg/package-object-renames
branch
from
752f9c4 to
081095c
Compare
OwenKephart
approved these changes
Apr 8, 2025
| def _all_packages_object_table( | ||
| registry: RemotePackageRegistry, name_only: bool, feature: Optional[PackageObjectFeature] | ||
| def _all_plugins_object_table( | ||
| registry: RemotePluginRegistry, name_only: bool, feature: Optional[PluginObjectFeature] | ||
| ) -> Table: | ||
| table = DagsterOuterTable(["Package"] if name_only else ["Package", "Objects"]) |
There was a problem hiding this comment.
Should this be updated to "Plugin"?
Note that that's a slightly annoying change because test_list_commands.py hardcodes the expected output (we should really convert those to snapshot tests to make our lives easier)
| ) | ||
| @dg_global_options | ||
| @cli_telemetry_wrapper | ||
| def list_packages_command( | ||
| def list_plugins_command( | ||
| name_only: bool, | ||
| package: Optional[str], |
There was a problem hiding this comment.
note the AI's comment here (oops that this is not under test)
smackesey
force-pushed
the
sean/dg/package-object-renames
branch
from
081095c to
7a42174
Compare
smackesey
force-pushed
the
sean/dg/package-object-renames
branch
from
7a42174 to
4be0e00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Collection of renames of abstractions related to the
dg list pluginscommand.dg list packages->dg list pluginsPackageObjectKey->PluginObjectKeyPackageObjectSnap->PluginObjectSnapPackageObjectFeatureData->PluginObjectFeatureDataRemotePackageRegistry->RemotePluginRegistryHow I Tested These Changes
Existing test suite.