feat(funnels): Informative Screen and StepHeadline component #4321
+469
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…app-directory-helloworld
…app-directory-helloworld
…app-directory-helloworld
Co-authored-by: Ante Barić <ante@kickass.website>
…nto feat-app-directory-helloworld
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
ilasw
reviewed
Apr 4, 2025
packages/shared/src/styles/base.css
Outdated
Comment on lines
811
to
829
| .bg-gradient-funnel { | ||
| &-default { | ||
| background: radial-gradient(100% 22.49% at 100% -10%, var(--theme-accent-cabbage-default) 0%, var(--theme-accent-cabbage-baseline) 100%), | ||
| radial-gradient(100% 22.49% at 0% -10%, var(--theme-accent-onion-default) 0%, var(--theme-accent-onion-baseline) 100%); | ||
| } | ||
|
|
||
| &-top { | ||
| background: radial-gradient(192.5% 100% at 50% 0%, var(--theme-accent-cabbage-default) 0%, var(--theme-accent-onion-default) 50%, var(--theme-accent-onion-baseline) 100%); | ||
| } | ||
|
|
||
| &-circle { | ||
| background: radial-gradient(94% 48.83% at 50% 0%, var(--theme-accent-cabbage-default) 0%, var(--theme-accent-onion-default) 75.12%, var(--theme-accent-onion-baseline) 100%); | ||
| } | ||
|
|
||
| &-hourglass { | ||
| background: radial-gradient(192.5% 100% at 50% 100%, #CE3DF3 0%, rgba(206, 61, 243, 0) 50%), | ||
| radial-gradient(192.5% 100% at 50% 0%, #7147ED 0%, rgba(113, 71, 237, 0) 50%); | ||
| } | ||
| } |
There was a problem hiding this comment.
Added those gradient using theme variables cc @rebelchris @sshanzel
There was a problem hiding this comment.
Ah ok it's better like this yeah :)
Not 100% ideal but let's go with this.
rebelchris
reviewed
Apr 4, 2025
packages/shared/src/styles/base.css
Outdated
| /** | ||
| * Current old colors, these should all be changed to one of the above matching ones. | ||
| */ | ||
| --theme-active: theme('colors.raw.salt.90') 33; |
There was a problem hiding this comment.
This space will break the usage :)
There was a problem hiding this comment.
@rebelchris reverted space changes 🙏
rebelchris
requested changes
Apr 4, 2025
packages/shared/src/styles/base.css
Outdated
Comment on lines
811
to
829
| .bg-gradient-funnel { | ||
| &-default { | ||
| background: radial-gradient(100% 22.49% at 100% -10%, var(--theme-accent-cabbage-default) 0%, var(--theme-accent-cabbage-baseline) 100%), | ||
| radial-gradient(100% 22.49% at 0% -10%, var(--theme-accent-onion-default) 0%, var(--theme-accent-onion-baseline) 100%); | ||
| } | ||
|
|
||
| &-top { | ||
| background: radial-gradient(192.5% 100% at 50% 0%, var(--theme-accent-cabbage-default) 0%, var(--theme-accent-onion-default) 50%, var(--theme-accent-onion-baseline) 100%); | ||
| } | ||
|
|
||
| &-circle { | ||
| background: radial-gradient(94% 48.83% at 50% 0%, var(--theme-accent-cabbage-default) 0%, var(--theme-accent-onion-default) 75.12%, var(--theme-accent-onion-baseline) 100%); | ||
| } | ||
|
|
||
| &-hourglass { | ||
| background: radial-gradient(192.5% 100% at 50% 100%, #CE3DF3 0%, rgba(206, 61, 243, 0) 50%), | ||
| radial-gradient(192.5% 100% at 50% 0%, #7147ED 0%, rgba(113, 71, 237, 0) 50%); | ||
| } | ||
| } |
There was a problem hiding this comment.
Ah ok it's better like this yeah :)
Not 100% ideal but let's go with this.
rebelchris
reviewed
Apr 7, 2025
packages/shared/tailwind/colors.ts
Outdated
| @@ -93,6 +93,7 @@ const colors = { | |||
| 90: '#D9113A', | |||
| }, | |||
| cabbage: { | |||
| 0: '#E669FB00', | |||
There was a problem hiding this comment.
We probably have this already no? it's just a gradient version.
We use the color-mix for that normally.
There was a problem hiding this comment.
I don't think this variable ended up being used at all, so I removed it
ilasw
approved these changes
Apr 8, 2025
rebelchris
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Informative Step of the web funnel. Can also be reused for "McKInsey Graph" as it seems to be the same component, just with image / text reversed.
Samples
Informative:
McKinsey:
Events
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
Jira ticket
MI-847
Preview domain
https://mi-847.preview.app.daily.dev