feat: add award notification #4354
Merged
+54
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omBratteng
requested review from
rebelchris,
ilasw,
capJavert,
sshanzel,
nensidosari and
AmarTrebinjac
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
packages/shared/src/components/notifications/utils.ts:17
- [nitpick] The name 'CoreIcon' is ambiguous considering the award notification context; consider renaming it to 'AwardIcon' for clearer intent.
CoreIcon,
packages/shared/src/components/notifications/utils.ts:75
- [nitpick] The icon type 'Core' is unclear; renaming it to 'Award' could improve clarity with respect to its usage for award notifications.
Core = 'Core',
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Jira ticket
AS-987
AS-1050
Preview domain
https://as-1050-award-notification.preview.app.daily.dev