Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(funnels): checkout step #4355

Merged
merged 4 commits into from
Apr 8, 2025
Merged

feat(funnels): checkout step #4355

merged 4 commits into from
Apr 8, 2025

Conversation

idoshamun
Copy link
Member

@idoshamun idoshamun commented Apr 7, 2025

Introduce a checkout step which shows paddle checkout in fullscreen and transitions to next step on checkout.

Simple as it sounds, it required some changes to how we use paddle. For the storybook support I had to use history instead of router, since storybook doesn't have a router.

MI-843 #done

Jira ticket

MI-843

Preview domain

https://mi-843.preview.app.daily.dev

Introduce a checkout step which shows paddle checkout in fullscreen and transitions to next step on checkout.

Simple as it sounds, it required some changes to how we use paddle. For the storybook support I had to use history instead of router, since storybook doesn't have a router.

MI-843 #done
@idoshamun idoshamun requested a review from a team as a code owner April 7, 2025 14:34
@idoshamun idoshamun requested review from rebelchris, omBratteng, ilasw, capJavert, sshanzel, nensidosari and AmarTrebinjac and removed request for a team April 7, 2025 14:34
Copy link

vercel bot commented Apr 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
daily-webapp ✅ Ready (Inspect) Visit Preview Apr 8, 2025 8:49am
storybook 🔄 Building (Inspect) Visit Preview Apr 8, 2025 8:49am

@@ -7,7 +7,7 @@ export const useRouterQuery = (): {
const params = useSearchParams();
return useMemo(
() => ({
query: Object.fromEntries(params.entries()),
query: params ? Object.fromEntries(params.entries()) : {},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also broke storybook

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, useSearchParams can return null

@@ -0,0 +1,138 @@
import { useState, useEffect, useRef } from 'react';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hook has less constraints on how we use paddle and primarily initialize it with the right tracking and nothing more

});

useEffect(() => {
if (!isPlusAvailable || isPlus || !paddle) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If its not a valid region, how does the user continue the funnel from here? As far as I can see we don't render any continue button or anything? 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a good question. i'll raise with product

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will safeguard this case and redirect to onboarding as part of the funnel page

Copy link
Contributor

@rebelchris rebelchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking, just a sanity check

@idoshamun idoshamun merged commit 0519ca6 into feat-web-funnel Apr 8, 2025
1 of 4 checks passed
@idoshamun idoshamun deleted the MI-843 branch April 8, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants