refactor: payment context to follow the new flow of fetching from API #4356
Conversation
sshanzel
requested review from
rebelchris,
omBratteng,
ilasw,
capJavert,
nensidosari and
AmarTrebinjac
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
There was a problem hiding this comment.
Nice work!
Big PR and very critical so we might need to define some new critical flows for purchases, can you maybe set a confluence page up for this? (CC: @idoshamun )
Also would like to have @omBratteng look at it for the IAP stuff.
In general looks ok, minor question around the extension layer.
| return duration === PlusPriceType.Yearly ? 0 : 1; | ||
| }) | ||
| .at(0), | ||
| productOptions.find( |
There was a problem hiding this comment.
Wondering if we should just expose this early adopter package in the context already so it's uniform?
| staleTime: StaleTime.Default, | ||
| }); | ||
|
|
||
| const giftOneYear = useMemo( |
There was a problem hiding this comment.
I mean we could expose the earlyAdopted like this :)
| @@ -64,25 +42,25 @@ export const PaddleSubProvider = ({ | |||
| eventCallback: (event: PaddleEventData) => { | |||
| switch (event?.name) { | |||
| case CheckoutEventNames.CHECKOUT_PAYMENT_INITIATED: | |||
| logRef.current({ | |||
| logRef.current?.({ | |||
| if (checkIsExtension()) { | ||
| return <ChromeExtensionProvider>{children}</ChromeExtensionProvider>; | ||
| } |
There was a problem hiding this comment.
Is this correct though?
I can actually show prices now right, it just can't handle checkout.
|
I agree with @rebelchris, this will have to be thoroughly tested and we should define critical flows for payment. We will need it for web funnels as well |
Changes
isTrial ? 'success' : 'help', etc.BasePaymentProviderthat will handle common PaymentContextProviders like the one for Paddle and Extension. Most logics are stored from the base provider then any requirements based on platform will be hosted on their respective contexts.earlyAdopterIdprop as it is not being used anymore.StoreKitprovider to fetch the metadata for easier maintenance of metadata.To test this locally, you can simply pull this PR for API until it is merged: dailydotdev/daily-api#2741
After that, everything should work out of the box.
Events
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
Jira ticket
MI-853
Preview domain
https://mi-853.preview.app.daily.dev