feat(funnels): Loading screen #4357
Open
+795
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…app-directory-helloworld
…app-directory-helloworld
…app-directory-helloworld
Co-authored-by: Ante Barić <[email protected]>
…nto feat-app-directory-helloworld
AmarTrebinjac
requested review from
rebelchris,
omBratteng,
ilasw,
capJavert,
sshanzel and
nensidosari
rebelchris
reviewed
Apr 8, 2025
packages/shared/src/features/onboarding/steps/FunnelLoading.tsx
Outdated
Show resolved
Hide resolved
packages/shared/src/features/onboarding/steps/FunnelLoading.tsx
Outdated
Show resolved
Hide resolved
packages/shared/src/features/onboarding/steps/FunnelLoading.tsx
Outdated
Show resolved
Hide resolved
packages/shared/src/features/onboarding/steps/FunnelLoading.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Thank you Mr. Claude for the animation
Screen.Recording.2025-04-08.at.15.42.00.mov
(Errors unrelated to this task)
I made it so that the progress has some stops, as to simulate "real" loading more accurately, rather than fill it continuously.After feedback from Tsahi, we do only 1 stop at 40.
DESIGN
Events
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
Preview domain
https://funnel-loading.preview.app.daily.dev