feat: useStepTransition #4361
feat: useStepTransition #4361
Conversation
Introduce new hook to dispatch the transition request
idoshamun
requested review from
rebelchris,
omBratteng,
ilasw,
capJavert,
sshanzel,
nensidosari and
AmarTrebinjac
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| export interface StepTransitionPayload { | ||
| fromStep: string; | ||
| toStep: string | null; | ||
| transitionEvent: string; |
There was a problem hiding this comment.
Maybe we can use FunnelStepTransitionType?
| fromStep: string; | ||
| toStep: string | null; | ||
| transitionEvent: string; | ||
| inputs?: StepInputs; |
There was a problem hiding this comment.
This can be the answer of a quiz, the selected pricing, or any other info we want to store
|
|
||
| export type UseStepTransitionRet = { | ||
| transition: UseMutateAsyncFunction<void, HttpError, StepTransitionPayload>; | ||
| isLoading: boolean; |
There was a problem hiding this comment.
I think at some point we agreed to use isPending instead of isLoading as a general rule. Not sure how much we enforce it still
There was a problem hiding this comment.
If it's a react-query mimic yeah we should use isPending.
They are 2 different thing, but the previous isLoading is now isPending.
There was a problem hiding this comment.
I am using isPending, just renamed it to isLoading as you can see below
There was a problem hiding this comment.
Yes, but what I meant is that we agreed to use the isPending name, not isLoading on a project level 😅
Introduce new hook to dispatch the transition request
MI-858 #done
Jira ticket
MI-858
Preview domain
https://mi-858.preview.app.daily.dev