An OpenFeign Client for Dapr Invokes #1294
Open
+2,048
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A OpenFeign Client and it's AutoConfiguration using Dapr Invoke APIs. Splited into two librarys, dapr-openfeign-client is the pure client of OpenFeign, and dapr-spring-openfeign is the plugin of Spring Cloud OpenFeign. Currently only HTTP Invoke Method and Invoke Binding supported, and Invoke Binding is not always recommend to use this client, depends on what binding component is. Signed-off-by: lony2003 <[email protected]>
A OpenFeign Client and it's AutoConfiguration using Dapr Invoke APIs. Splited into two librarys, dapr-openfeign-client is the pure client of OpenFeign, and dapr-spring-openfeign is the plugin of Spring Cloud OpenFeign. Currently only HTTP Invoke Method and Invoke Binding supported, and Invoke Binding is not always recommend to use this client, depends on what binding component is. Signed-off-by: lony2003 <[email protected]>
A OpenFeign Client and it's AutoConfiguration using Dapr Invoke APIs. Splited into two librarys, dapr-openfeign-client is the pure client of OpenFeign, and dapr-spring-openfeign is the plugin of Spring Cloud OpenFeign. Currently only HTTP Invoke Method and Invoke Binding supported, and Invoke Binding is not always recommend to use this client, depends on what binding component is. Signed-off-by: lony2003 <[email protected]>
this example can redirect order request to producer-app. It needs producer-app to run properly. Signed-off-by: lony2003 <[email protected]>
this test tests the PostgreSQL binding of dapr. Signed-off-by: lony2003 <[email protected]>
Signed-off-by: lony2003 <[email protected]>
|
I haven't reviewed this yet @lony2003 , but I am more convinced that we need this .. @artur-ciocanu @mcruzdev can you help me to check this PR ? |
lony2003
commented
Apr 2, 2025
...n/src/main/java/io/dapr/spring/openfeign/autoconfigure/DaprFeignClientAutoConfiguration.java
Outdated
Show resolved
Hide resolved
Fix the example doc to make openfeign app works in mm.py Signed-off-by: lony2003 <[email protected]>
|
@lony2003 I've just reviewed this PR and it is looking awesome.. |
…riginal Targeter beans instead of override them. Signed-off-by: lony2003 <[email protected]>
|
@salaboy I have changed the |
cicoyle
reviewed
Apr 7, 2025
...gn-app/src/main/java/io/dapr/springboot/examples/openfeign/ProducerClientRestController.java
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1294 +/- ##
============================================
- Coverage 76.91% 75.10% -1.82%
- Complexity 1592 1656 +64
============================================
Files 145 201 +56
Lines 4843 5314 +471
Branches 562 575 +13
============================================
+ Hits 3725 3991 +266
- Misses 821 997 +176
- Partials 297 326 +29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: lony2003 <[email protected]>
…ingMessagingIT works Signed-off-by: lony2003 <[email protected]>
…oot 3.3.x Signed-off-by: lony2003 <[email protected]>
…gIT works Signed-off-by: lony2003 <[email protected]>
|
@cicoyle I have checked all files and add headers for them, and I have solved the problem that makes IT failed. Please re-trigger the CI. |
|
Hey @lony2003 - thanks, before I can retrigger CI it says there are conflicts needing to be resolved. Mind resolving them locally and pushing? Then we'll be able to proceed 🙏🏻 |
Signed-off-by: lony2003 <[email protected]>
lony2003
force-pushed
the
development-openfeign
branch
from
8580167 to
a330ef2
Compare
…R_RUNTIME_IMAGE_TAG Signed-off-by: lony2003 <[email protected]>
lony2003
force-pushed
the
development-openfeign
branch
4 times, most recently
from
8befe0e to
6d1e70a
Compare
lony2003
force-pushed
the
development-openfeign
branch
3 times, most recently
from
3eaa83e to
c381e44
Compare
… client bean autowired Job SDK ITs have a daprPreviewClient bean defined, as SpringBoot bean search will first get beans that impl the interface and get all beans that matches the bean's class, when openfeign autowire DaprClient, there is a conflict between daprClient and daprPreviewClient. Change the AutoConfiguration behavior to make a more strict rule for making AutoConfiguration run Signed-off-by: lony2003 <[email protected]>
lony2003
force-pushed
the
development-openfeign
branch
4 times, most recently
from
00fae6b to
bc6d98c
Compare
… client bean autowired Job SDK ITs have a daprPreviewClient bean defined, as SpringBoot bean search will first get beans that impl the interface and get all beans that matches the bean's class, when openfeign autowire DaprClient, there is a conflict between daprClient and daprPreviewClient. Change the AutoConfiguration behavior to make a more strict rule for making AutoConfiguration run Signed-off-by: lony2003 <[email protected]>
change APP_PORT to 8082 Signed-off-by: lony2003 <[email protected]>
|
@cicoyle conflict solved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A OpenFeign Client and it's AutoConfiguration using Dapr Invoke APIs.
Splited into two librarys, dapr-openfeign-client is the pure client of OpenFeign, and dapr-spring-openfeign is the plugin of Spring Cloud OpenFeign.
Currently only HTTP Invoke Method and Invoke Binding supported, and Invoke Binding is not always recommend to use this client, depends on what binding component is.
Issue reference
this PR will close: #1181
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: