Skip to content

Fix URL building logic #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

artur-ciocanu
Copy link
Contributor

Description

This is a tiny PR that fixes the URL building logic in the DaprHttp functionality. This is trying to fix an issue where we tried to replace the OkHttp URL builder with something that uses JDK URI.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1314

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@artur-ciocanu artur-ciocanu requested review from a team as code owners April 21, 2025 16:33
@artur-ciocanu
Copy link
Contributor Author

@rahulpoddar-fyndna and @vikram-mahadevkar this is the fix for #1314. We hope to release it as soon as possible.

@artur-ciocanu
Copy link
Contributor Author

@cicoyle @mcruzdev @salaboy could you please take a look. This might need a hot fix.

@artur-ciocanu artur-ciocanu force-pushed the gh-1314 branch 2 times, most recently from 6de971a to bb030d1 Compare April 23, 2025 15:03
Artur Ciocanu added 3 commits April 23, 2025 10:14
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Artur Ciocanu added 5 commits April 23, 2025 13:21
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Copy link

codecov bot commented Apr 24, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 77.13%. Comparing base (d759c53) to head (cd116aa).
Report is 133 commits behind head on master.

Files with missing lines Patch % Lines
sdk/src/main/java/io/dapr/client/DaprHttp.java 50.00% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1320      +/-   ##
============================================
+ Coverage     76.91%   77.13%   +0.21%     
- Complexity     1592     1728     +136     
============================================
  Files           145      200      +55     
  Lines          4843     5291     +448     
  Branches        562      579      +17     
============================================
+ Hits           3725     4081     +356     
- Misses          821      897      +76     
- Partials        297      313      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dapr SDK 1.14.0 Issue with Slash "\" in URI
3 participants