-
Notifications
You must be signed in to change notification settings - Fork 215
Fix URL building logic #1320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix URL building logic #1320
Conversation
@rahulpoddar-fyndna and @vikram-mahadevkar this is the fix for #1314. We hope to release it as soon as possible. |
sdk-tests/src/test/java/io/dapr/it/methodinvoke/http/GH_1314_IT.java
Outdated
Show resolved
Hide resolved
6de971a
to
bb030d1
Compare
sdk-tests/src/test/java/io/dapr/it/methodinvoke/http/GH_1314_IT.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1320 +/- ##
============================================
+ Coverage 76.91% 77.13% +0.21%
- Complexity 1592 1728 +136
============================================
Files 145 200 +55
Lines 4843 5291 +448
Branches 562 579 +17
============================================
+ Hits 3725 4081 +356
- Misses 821 897 +76
- Partials 297 313 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
This is a tiny PR that fixes the URL building logic in the DaprHttp functionality. This is trying to fix an issue where we tried to replace the OkHttp URL builder with something that uses JDK URI.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1314
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: