-
Notifications
You must be signed in to change notification settings - Fork 219
Aligning Spring Boot and SpringFramework versions #1427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@salaboy I think this PR will fix the build issue #1425. If you could review this, I can request @artur-ciocanu to merge it and you could pull the changes |
18917f4
to
024efa9
Compare
@salaboy could you please get rid of logback dependency, I don't think we need it, if it is coming from Spring. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@salaboy the PR looks good, I just think that we need to get rid of logback, so it comes with Spring as a transitive dependency.
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Removing dependencies should be a holidays activity :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1427 +/- ##
============================================
+ Coverage 76.91% 78.51% +1.59%
- Complexity 1592 1867 +275
============================================
Files 145 230 +85
Lines 4843 5790 +947
Branches 562 601 +39
============================================
+ Hits 3725 4546 +821
- Misses 821 924 +103
- Partials 297 320 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Updating version and aligning with internal SpringFramework deps
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1426
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: