Skip to content

Aligning Spring Boot and SpringFramework versions #1427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 26, 2025

Conversation

salaboy
Copy link
Collaborator

@salaboy salaboy commented Jun 17, 2025

Description

Updating version and aligning with internal SpringFramework deps

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1426

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@salaboy salaboy requested review from a team as code owners June 17, 2025 01:37
siri-varma
siri-varma previously approved these changes Jun 17, 2025
Copy link
Contributor

@siri-varma siri-varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siri-varma
Copy link
Contributor

@salaboy I think this PR will fix the build issue #1425. If you could review this, I can request @artur-ciocanu to merge it and you could pull the changes

@salaboy salaboy force-pushed the 1426-sb-version branch 2 times, most recently from 18917f4 to 024efa9 Compare June 17, 2025 03:13
@artur-ciocanu
Copy link
Contributor

@salaboy could you please get rid of logback dependency, I don't think we need it, if it is coming from Spring.

artur-ciocanu
artur-ciocanu previously approved these changes Jun 19, 2025
Copy link
Contributor

@artur-ciocanu artur-ciocanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@salaboy the PR looks good, I just think that we need to get rid of logback, so it comes with Spring as a transitive dependency.

@cicoyle
Copy link
Contributor

cicoyle commented Jun 20, 2025

@salaboy the PR looks good, I just think that we need to get rid of logback, so it comes with Spring as a transitive dependency.

sgtm - we can wait for that to be removed then merge

@salaboy is on vacation thru next friday. So I don't think he'll update it until then

@salaboy
Copy link
Collaborator Author

salaboy commented Jun 26, 2025

Removing dependencies should be a holidays activity :)
Done @dapr/maintainers-java-sdk

Copy link
Contributor

@artur-ciocanu artur-ciocanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@dapr-bot dapr-bot merged commit 8c2c2ee into dapr:master Jun 26, 2025
9 checks passed
Copy link

codecov bot commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.51%. Comparing base (d759c53) to head (87f5924).
Report is 173 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1427      +/-   ##
============================================
+ Coverage     76.91%   78.51%   +1.59%     
- Complexity     1592     1867     +275     
============================================
  Files           145      230      +85     
  Lines          4843     5790     +947     
  Branches        562      601      +39     
============================================
+ Hits           3725     4546     +821     
- Misses          821      924     +103     
- Partials        297      320      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Spring Boot to 3.4.6 and align Spring version
5 participants