Skip to content

add Sony ILCE-1M2 noise profiles #18845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zechenturm
Copy link

Addresses #18844

@TurboGit TurboGit self-assigned this May 20, 2025
@TurboGit TurboGit added this to the 5.2 milestone May 20, 2025
@TurboGit TurboGit added the scope: noise profile adding noise profiles for new cameras label May 20, 2025
@kmilos
Copy link
Contributor

kmilos commented May 20, 2025

Btw, the noise profile doesn't depend on the input color matrix, right?

@zechenturm
Copy link
Author

Honestly, no idea , I just followed the tutorial. What I do know is that the profiles work great for me testing locally, though given that I'm testing with the exact camera that created the profiles that might not say much. How could we/I test that?

@kmilos
Copy link
Contributor

kmilos commented May 21, 2025

How could we/I test that?

If you created the noise profile w/ a recent (after March 21) nightly build, than everything should be ok.

If you created it w/ 5.0.x, the color matrix will change in a future dt version (most likely in the upcoming 5.2). You can test the change here: darktable-org/rawspeed@2579537

@zechenturm
Copy link
Author

zechenturm commented May 21, 2025

Ok, thanks for the info. I'm using darktable 5.0.1 as shipped by Arch. I've manually edited /usr/share/darktable/rawspeed/cameras.xml to contain the new color matrix values and regenerated the noise profiles. According to diff they are identical. So I think we're good.

If anyone wants to double check: darktable-noiseprofile-20250521.tar.gz

@kmilos
Copy link
Contributor

kmilos commented May 21, 2025

As expected, thanks for checking!

@zechenturm
Copy link
Author

My pleasure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: noise profile adding noise profiles for new cameras
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants