Skip to content

Add an example client to execute a workflow #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 25, 2025
Merged

Conversation

kenzieschmoll
Copy link
Contributor

No description provided.

Copy link

PR Health

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Copy link
Contributor

@jakemac53 jakemac53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, we should move some of this logic out to a shared library before landing though :D.

3) Fix all errors and warnings that you can
4) Hot reload the changes to the running app
5) Check for runtime errors
6) Fix any runtime errors that you can
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it ask the user at this point to try out the app, and then it can listen for any additional runtime errors, or the user can give other feedback before proceeding?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once it is done it does ask if there is anything else the user would like. Often times the steps it generates checks for runtime errors a second time after applying changes.

@kenzieschmoll kenzieschmoll marked this pull request as ready for review April 25, 2025 01:23
@kenzieschmoll
Copy link
Contributor Author

we should move some of this logic out to a shared library before landing though :D.

Filed #86 to do this as a follow up.

@auto-submit auto-submit bot merged commit a4b53d2 into main Apr 25, 2025
24 checks passed
@auto-submit auto-submit bot deleted the workflow-client branch April 25, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants