-
Notifications
You must be signed in to change notification settings - Fork 6
Add an example client to execute a workflow #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, we should move some of this logic out to a shared library before landing though :D.
3) Fix all errors and warnings that you can | ||
4) Hot reload the changes to the running app | ||
5) Check for runtime errors | ||
6) Fix any runtime errors that you can |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it ask the user at this point to try out the app, and then it can listen for any additional runtime errors, or the user can give other feedback before proceeding?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once it is done it does ask if there is anything else the user would like. Often times the steps it generates checks for runtime errors a second time after applying changes.
Filed #86 to do this as a follow up. |
No description provided.