Skip to content

Store errors in the asset graph instead of separate files. #4013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025

Conversation

davidmorgan
Copy link
Contributor

@davidmorgan davidmorgan commented May 20, 2025

For #4005.

Simplify error handling in preparation for changes to logging.

Errors need to be serialized so they can be reported again instead of rebuilding if there is no reason to rebuild. Prior to this PR they are serialized separately to the asset graph, now they are part of the asset graph.

Copy link

github-actions bot commented May 20, 2025

PR Health

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

@davidmorgan davidmorgan changed the title Store errrors in the asset graph instead of separate files. Store errors in the asset graph instead of separate files. May 20, 2025
@davidmorgan davidmorgan marked this pull request as ready for review May 20, 2025 07:28
@davidmorgan davidmorgan requested a review from jensjoha May 20, 2025 07:28
@davidmorgan davidmorgan merged commit d4fd712 into dart-lang:master May 22, 2025
75 checks passed
@davidmorgan davidmorgan deleted the failure-log branch May 22, 2025 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants