-
Notifications
You must be signed in to change notification settings - Fork 28
#3057. Add switch expression/statement tests for promotion #3147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! But we definitely need some tests where one or more cases are labelled, because the labelled cases are treated differently.
TypeSystem/flow-analysis/reachability_switch_expression_A04_t03.dart
Outdated
Show resolved
Hide resolved
TypeSystem/flow-analysis/reachability_switch_expression_A04_t03.dart
Outdated
Show resolved
Hide resolved
TypeSystem/flow-analysis/reachability_switch_expression_A04_t03.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Updated. Labelled cases are added. PTAL.
TypeSystem/flow-analysis/reachability_switch_expression_A04_t03.dart
Outdated
Show resolved
Hide resolved
TypeSystem/flow-analysis/reachability_switch_expression_A04_t03.dart
Outdated
Show resolved
Hide resolved
TypeSystem/flow-analysis/reachability_switch_expression_A04_t03.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2025-06-19 [email protected] dart-lang/co19#3180. Add more `js_interop` tests (dart-lang/co19#3232) 2025-06-18 [email protected] dart-lang/co19#3180. Add more JSAnyOperatorExtension tests (dart-lang/co19#3225) 2025-06-18 [email protected] dart-lang/co19#3180. Add more `JSArray` and `JSArrayBuffer` tests (dart-lang/co19#3230) 2025-06-17 [email protected] dart-lang/co19#1401. Add additional tests for shared case scoping (dart-lang/co19#3174) 2025-06-17 [email protected] dart-lang/co19#3180. Add `JSArray` tests. (dart-lang/co19#3229) 2025-06-16 [email protected] dart-lang/co19#3057. Add switch expression/statement tests for promotion (dart-lang/co19#3147) 2025-06-16 [email protected] dart-lang/co19#3057. Expect error in reachability_for_A03_t05.dart test. (dart-lang/co19#3132) 2025-06-16 [email protected] dart-lang/co19#3057. Add pattern assignment cases to C-style for tests (dart-lang/co19#3126) 2025-06-16 [email protected] Fixes dart-lang/co19#3227. Use `unspecified` error expectation (dart-lang/co19#3228) 2025-06-16 [email protected] dart-lang/co19#3180. Simplify JSAnyOperation tests. (dart-lang/co19#3223) Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try Change-Id: I8331e117e8f66469381fdefef59cdbef4a4fd06f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/435784 Commit-Queue: Alexander Thomas <[email protected]> Reviewed-by: Chloe Stefantsova <[email protected]> Reviewed-by: Alexander Thomas <[email protected]>
No description provided.