Add support for same on POSIX
#211
Conversation
| /// Links are resolved before determining if the paths refer to the same | ||
| /// object. Throws `PathNotFoundException` if either path requires resolving | ||
| /// a broken link. | ||
| /// ``` |
| bool same(String path1, String path2) { | ||
| throw UnsupportedError('same'); | ||
| } | ||
|
|
There was a problem hiding this comment.
Maybe just not have this method, if it's not supported on all file systems.
Only have it on PosixFileSystem.
If you have to do is PosixFileSystem before you can use it safely, better just have to do that before being able to use it at all.
If you plan to implement it on all file systems, make it abstract here, to force an implementation.
There was a problem hiding this comment.
It will be implemented on all file systems.
| @@ -30,6 +30,18 @@ class WriteMode { | |||
|
|
|||
| /// An abstract representation of a file system. | |||
| base class FileSystem { | |||
There was a problem hiding this comment.
We've been discussing this at #202
I'll leave it unchanged here and hopefully we can come to a conclusion in that PR ;-)
| throw _getError(errno, 'stat failed', path2); | ||
| } | ||
|
|
||
| return (stat1.st_ino == stat2.st_ino) && (stat1.st_dev == stat2.st_dev); |
There was a problem hiding this comment.
This looks like it equates filled with the same inode. That means that hard links, non-symbolic links, to the same inode should be equal, even if they resolve to filled with different paths.
Should be tested too:
- two files linked to same inode.
- two different paths linked through hard links to the same directory.
Generally, test with targets that are directories too.
Do symlinks have inodes?
There was a problem hiding this comment.
This looks like it equates filled with the same inode. That means that hard links, non-symbolic links, to the same inode should be equal, even if they resolve to filled with different paths.
Yep.
Should be tested too:
- two files linked to same inode.
- two different paths linked through hard links to the same directory.
Will do. I'll need to make some upstream changes to package:stdlibc.
Generally, test with targets that are directories too.
I already do this.
Do symlinks have inodes?
Yes, but same resolves the symlink before checking the inode.
FileSystemEntity.identical does not resolve the final symlink but same does. For example:
Link('foo').create('bar');
FileSystemEntity.identical('foo', 'bar'); // false
same('foo', 'bar'); // trueI was thinking that maybe same should be called equivalent and then I could have an identical that behaves the same was as FileSystemEntity.identical. WDYT?
dart:io'sidenticalmethod because it resolves the final path component if it is a symlinkContribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.