Skip to content

ConstantReader.revive implementation now matches the documentation #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 10, 2018

Conversation

matanlurey
Copy link
Contributor

Closes #374.

... also prepare to release.

}
return null;
// We could try and return the "best" result more intelligently.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what value is this comment adding?

@matanlurey matanlurey merged commit 1e87e13 into dart-lang:master Sep 10, 2018
@matanlurey matanlurey deleted the private-revive branch September 10, 2018 19:28
mosuem pushed a commit to dart-lang/build that referenced this pull request Dec 10, 2024
mosuem pushed a commit to dart-lang/build that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants