Skip to content

ci: Try to reduce unittest memory usage #3929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jan 21, 2022

Signed-off-by: Xuanwo [email protected]

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

This PR intends to reduce memory usage during compiling.

It's a workaround inspired by rust-lang/rust#82406 (comment).

Hoping this can resolve the failed tests for databend.

Changelog

  • Build/Testing/CI

Test Plan

Unit Tests

Stateless Tests

@Xuanwo Xuanwo requested a review from BohuTANG as a code owner January 21, 2022 05:08
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

1 similar comment
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@databend-bot databend-bot added pr-build this PR changes build/testing/ci steps need-review labels Jan 21, 2022
@vercel
Copy link

vercel bot commented Jan 21, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/G62pWacsEW8atTAoGPdjS1FM7nVa
✅ Preview: Canceled

[Deployment for 0d62561 canceled]

@Xuanwo Xuanwo marked this pull request as draft January 21, 2022 05:08
@Xuanwo
Copy link
Member Author

Xuanwo commented Jan 21, 2022

I plan to rerun this PR's test_unit three time to make sure it really works.

Signed-off-by: Xuanwo <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #3929 (0d62561) into main (82e6e4c) will increase coverage by 0%.
The diff coverage is 87%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3929   +/-   ##
=====================================
  Coverage     56%     56%           
=====================================
  Files        800     801    +1     
  Lines      42754   42714   -40     
=====================================
- Hits       24350   24331   -19     
+ Misses     18404   18383   -21     
Impacted Files Coverage Δ
common/meta/raft-store/src/state/raft_state.rs 27% <ø> (ø)
common/meta/sled-store/src/sled_serde.rs 100% <ø> (ø)
common/meta/types/src/applied_state.rs 50% <ø> (ø)
common/meta/types/src/cluster.rs 88% <ø> (ø)
common/meta/types/src/cmd.rs 100% <ø> (ø)
common/meta/types/src/log_entry.rs 100% <ø> (ø)
common/meta/types/src/message.rs 95% <ø> (ø)
common/meta/types/src/raft_types.rs 33% <ø> (+16%) ⬆️
metasrv/src/errors.rs 24% <0%> (+<1%) ⬆️
metasrv/src/store/to_storage_error.rs 44% <44%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a89b24c...0d62561. Read the comment docs.

@Xuanwo
Copy link
Member Author

Xuanwo commented Jan 21, 2022

Oh, it's failed 😢

image

@Xuanwo Xuanwo closed this Jan 21, 2022
@Xuanwo Xuanwo deleted the reduce-ut-memory branch January 21, 2022 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-review pr-build this PR changes build/testing/ci steps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants