Skip to content

Nearest Genes Function #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

Nearest Genes Function #170

wants to merge 12 commits into from

Conversation

nleroy917
Copy link
Member

Given a query and set of annotations, this function will calculate
the nearest annotation to each region in the region set, as well
as the nearest gene type and the distance to the nearest gene.

This is updated from the previous version which wasn't functioning
properly!

The only issue I am having is that the function requires that the
annotation file has the name of the gene defined as gene_id
and the type of gene as gene_biotype. It would be nice to
introduce a keyword parameter that defaults to these two,
but can be changed to extract out this information should an
annotation file be given with different schema or naming convention.

However, I am having a hard time attempting to dynamically access these attributes. For example:

query$gene_type = annotation[nearestIds]$gene_type

versus

query$gene_type = annotations[nearestIds][key_name]

kkupkova and others added 10 commits July 8, 2021 15:01
#133 add dinucleotide frequency calculation
update vignettes, typo
nicer dinuc. plots and avoid build error in Bioconductor
fix build error on Windows (Bioconductor issue only)
one more bioconductor windows build fix
remove all bpProportion=T examples to avoid build error
mm10 specificity plots
@kkupkova kkupkova changed the base branch from master to dev November 30, 2021 23:20
@kkupkova
Copy link
Contributor

The function gives error. There is definitely a typo - check "annotation" and "annotations". Please test that the function works before you give it to check. Also, I don't think it would work with GRangesList at this point (check how all the other functions include code for GRangesList objects).

@nleroy917 nleroy917 closed this Dec 3, 2021
@nsheff
Copy link
Member

nsheff commented Jan 8, 2022

Did you confirm that this works with GRangesList objects?

@nsheff
Copy link
Member

nsheff commented Jan 8, 2022

I see now this was closed in favor of #172

It's good to put a note here for future reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants