Skip to content

fix: customizable cell sidebar doesn't work. #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025
Merged

fix: customizable cell sidebar doesn't work. #371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/react/src/components/notebook/cell/sidebar/CellSidebarExtension.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ class CellSidebarFactory implements IDisposable {
protected panel: NotebookPanel,
protected commands: CommandRegistry,
protected nbgrader: boolean = false,
protected sidebarWidth: number = 120
protected sidebarWidth: number = 120,
protected factory: React.JSXElementConstructor<ICellSidebarProps> = CellSidebar
) {
this._onModelChanged(panel.content);
panel.content.modelChanged.connect(this._onModelChanged, this);
Expand All @@ -59,9 +60,10 @@ class CellSidebarFactory implements IDisposable {
private _addSidebar(model: ICellModel): void {
const cell = this._getCell(model);
if (cell) {
const Element = this.factory;
const sidebar = ReactWidget.create(
<JupyterReactTheme>
<CellSidebar
<Element
commands={this.commands}
model={model}
nbgrader={this.nbgrader}
Expand Down Expand Up @@ -155,7 +157,8 @@ export class CellSidebarExtension implements DatalayerNotebookExtension {
panel,
this.commands!,
this.nbgrader,
this.sidebarWidth
this.sidebarWidth,
this.factory
);
return sidebar;
}
Expand Down
Loading