Skip to content

Allow scoped metadata to be undefined #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davidlj95 opened this issue Dec 17, 2023 · 1 comment · Fixed by #163
Closed

Allow scoped metadata to be undefined #92

davidlj95 opened this issue Dec 17, 2023 · 1 comment · Fixed by #163
Labels
enhancement New feature or request

Comments

@davidlj95
Copy link
Owner

Current route metadta types for scoped metadata (standard, open graph, open graph profile, ...) set the proper type but don't allow undefined to be there. So in case you define a generic type that may allow some kind of scoped metadata, but may not be there in some cases, you have to do some workarounds

For instance:
https://github.com/davidlj95/chrislb/blob/4982d6aac13954f570a421cecb76ab4d04cc75f2/src/app/common/routing/make-route-metadata.ts#L38-L38

To take into account in #90

@davidlj95 davidlj95 added the enhancement New feature or request label Dec 17, 2023
@davidlj95
Copy link
Owner Author

No longer an issue since refactor in #163

@davidlj95 davidlj95 linked a pull request Jan 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant