perf: remove metadata definition class #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
clean up unneeded base class files
📦 Bundle size (Angular v17)Git ref: 232dede
|
📦 Bundle size (Angular v15)Git ref: 232dede
|
📦 Bundle size (Angular v16)Git ref: 232dede
|
fix missing renames remove unneeded tests use helper method for dry in resolver test remove unneeded file
davidlj95
force-pushed
the
stacked/perf-remove-metadata-definition-class
branch
from
1ab1ba3 to
232dede
Compare
|
🎉 This PR is included in version 1.0.0-alpha.21 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In spirit of reducing bundle size, removing metadata definition classes hierarchy. And all those global / scoped stuff. Simplifies code + given they're making objects instead of declaring classes, code can be shortened hence gaining in performance too.
It also renames a bit of core names:
Metadata: now isMetadataProvider. Indicates more that provides functionality for a metadataMetadataDefinition: now is just metadata. Shorter :)Also, clean up unneeded files like:
BaseXMetadataDefinition: using functions instead now to generate thoseprovideMetadata: no longer needed, using provide metadata factory around