Skip to content

perf: reduce Twitter Card module bundle size #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2024

Conversation

davidlj95
Copy link
Owner

@davidlj95 davidlj95 commented Jan 13, 2024

Same as #150 but for Twitter Card

62-65% less bundle size, yay 🎉 Same as with Open Graph indeed.

Copy link
Owner Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link

github-actions bot commented Jan 13, 2024

📦 Bundle size (Angular v16)

Git ref: b336a21

Module file Size Base size Difference
ngx-meta-core.mjs 3970 bytes (3.9KiB) 3970 bytes (3.9KiB) No change
ngx-meta-json-ld.mjs 779 bytes (779B) 779 bytes (779B) No change
ngx-meta-open-graph-profile.mjs 1463 bytes (1.5KiB) 1463 bytes (1.5KiB) No change
ngx-meta-open-graph.mjs 1021 bytes (1021B) 1019 bytes (1019B) .19%: 2 bytes (2B)
ngx-meta-routing.mjs 1522 bytes (1.5KiB) 1522 bytes (1.5KiB) No change
ngx-meta-standard.mjs 3491 bytes (3.5KiB) 3491 bytes (3.5KiB) No change
ngx-meta-twitter-card.mjs 810 bytes (810B) 2169 bytes (2.2KiB) -62.65%: -1359 bytes (-1.4KiB)

Copy link

github-actions bot commented Jan 13, 2024

📦 Bundle size (Angular v17)

Git ref: b336a21

Module file Size Base size Difference
ngx-meta-core.mjs 3702 bytes (3.7KiB) 3701 bytes (3.7KiB) .02%: 1 bytes (1B)
ngx-meta-json-ld.mjs 600 bytes (600B) 600 bytes (600B) No change
ngx-meta-open-graph-profile.mjs 1278 bytes (1.3KiB) 1274 bytes (1.3KiB) .31%: 4 bytes (4B)
ngx-meta-open-graph.mjs 857 bytes (857B) 856 bytes (856B) .11%: 1 bytes (1B)
ngx-meta-routing.mjs 1307 bytes (1.3KiB) 1307 bytes (1.3KiB) No change
ngx-meta-standard.mjs 3190 bytes (3.2KiB) 3185 bytes (3.2KiB) .15%: 5 bytes (5B)
ngx-meta-twitter-card.mjs 648 bytes (648B) 1894 bytes (1.9KiB) -65.78%: -1246 bytes (-1.3KiB)

Copy link

github-actions bot commented Jan 13, 2024

📦 Bundle size (Angular v15)

Git ref: b336a21

Module file Size Base size Difference
ngx-meta-core.mjs 3974 bytes (3.9KiB) 3970 bytes (3.9KiB) .10%: 4 bytes (4B)
ngx-meta-json-ld.mjs 779 bytes (779B) 779 bytes (779B) No change
ngx-meta-open-graph-profile.mjs 1463 bytes (1.5KiB) 1463 bytes (1.5KiB) No change
ngx-meta-open-graph.mjs 1021 bytes (1021B) 1019 bytes (1019B) .19%: 2 bytes (2B)
ngx-meta-routing.mjs 1522 bytes (1.5KiB) 1522 bytes (1.5KiB) No change
ngx-meta-standard.mjs 3491 bytes (3.5KiB) 3491 bytes (3.5KiB) No change
ngx-meta-twitter-card.mjs 810 bytes (810B) 2169 bytes (2.2KiB) -62.65%: -1359 bytes (-1.4KiB)

@davidlj95 davidlj95 force-pushed the stacked/perf-reduce-Twitter-Card-module-bundle-size branch from ac3de7a to b336a21 Compare January 13, 2024 18:07
@davidlj95 davidlj95 merged commit c59da29 into main Jan 13, 2024
@davidlj95 davidlj95 deleted the stacked/perf-reduce-Twitter-Card-module-bundle-size branch January 13, 2024 18:58
@davidlj95 davidlj95 linked an issue Jan 13, 2024 that may be closed by this pull request
Copy link

🎉 This PR is included in version 1.0.0-alpha.18 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce bundle size
1 participant