-
Notifications
You must be signed in to change notification settings - Fork 1
perf: remove defaults serv to reduce core mod size #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: remove defaults serv to reduce core mod size #170
Conversation
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
📦 Bundle size (Angular v15)Git ref: bac6e84
|
📦 Bundle size (Angular v17)Git ref: bac6e84
|
📦 Bundle size (Angular v16)Git ref: bac6e84
|
🎉 This PR is included in version 1.0.0-alpha.24 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Ignore size comments, they're wrong. Given they didn't succeed first time given on a random CI failure. And second time they were generated comparing against themselves as this PR was merged and the last commit on main. Soo obviously no diff since code is same |
From local markdown I can tell you we shaved 230 bytes on Angular v17 😬 |
It doesn't add any capability right now. It was added in case we wanted to add more capabilities to the defaults mechanism (like scoped defaults per route group). But until that happens, let's shave off some bytes.
Mostly due to
class
syntax + class propertydefaults
and@Injectable
bytes