Skip to content

perf: remove defaults serv to reduce core mod size #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

davidlj95
Copy link
Owner

It doesn't add any capability right now. It was added in case we wanted to add more capabilities to the defaults mechanism (like scoped defaults per route group). But until that happens, let's shave off some bytes.

Mostly due to class syntax + class property defaults and @Injectable bytes

Copy link
Owner Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@davidlj95 davidlj95 enabled auto-merge (squash) January 15, 2024 15:22
@davidlj95 davidlj95 merged commit ba47952 into main Jan 15, 2024
@davidlj95 davidlj95 deleted the stacked/perf-remove-defaults-serv-to-reduce-core-mod-size branch January 15, 2024 15:23
Copy link

github-actions bot commented Jan 15, 2024

📦 Bundle size (Angular v15)

Git ref: bac6e84

Module file Size Base size Difference
ngx-meta-core.mjs 3182 bytes (3.2KiB) 3182 bytes (3.2KiB) No change
ngx-meta-json-ld.mjs 470 bytes (470B) 470 bytes (470B) No change
ngx-meta-open-graph-profile.mjs 423 bytes (423B) 423 bytes (423B) No change
ngx-meta-open-graph.mjs 900 bytes (900B) 900 bytes (900B) No change
ngx-meta-routing.mjs 1522 bytes (1.5KiB) 1522 bytes (1.5KiB) No change
ngx-meta-standard.mjs 1603 bytes (1.6KiB) 1603 bytes (1.6KiB) No change
ngx-meta-twitter-card.mjs 689 bytes (689B) 689 bytes (689B) No change

Copy link

github-actions bot commented Jan 15, 2024

📦 Bundle size (Angular v17)

Git ref: bac6e84

Module file Size Base size Difference
ngx-meta-core.mjs 2921 bytes (2.9KiB) 2921 bytes (2.9KiB) No change
ngx-meta-json-ld.mjs 296 bytes (296B) 296 bytes (296B) No change
ngx-meta-open-graph-profile.mjs 286 bytes (286B) 286 bytes (286B) No change
ngx-meta-open-graph.mjs 734 bytes (734B) 734 bytes (734B) No change
ngx-meta-routing.mjs 1307 bytes (1.3KiB) 1307 bytes (1.3KiB) No change
ngx-meta-standard.mjs 1444 bytes (1.5KiB) 1444 bytes (1.5KiB) No change
ngx-meta-twitter-card.mjs 525 bytes (525B) 525 bytes (525B) No change

Copy link

github-actions bot commented Jan 15, 2024

📦 Bundle size (Angular v16)

Git ref: bac6e84

Module file Size Base size Difference
ngx-meta-core.mjs 3178 bytes (3.2KiB) 3178 bytes (3.2KiB) No change
ngx-meta-json-ld.mjs 470 bytes (470B) 470 bytes (470B) No change
ngx-meta-open-graph-profile.mjs 423 bytes (423B) 423 bytes (423B) No change
ngx-meta-open-graph.mjs 900 bytes (900B) 900 bytes (900B) No change
ngx-meta-routing.mjs 1522 bytes (1.5KiB) 1522 bytes (1.5KiB) No change
ngx-meta-standard.mjs 1603 bytes (1.6KiB) 1603 bytes (1.6KiB) No change
ngx-meta-twitter-card.mjs 689 bytes (689B) 689 bytes (689B) No change

Copy link

🎉 This PR is included in version 1.0.0-alpha.24 🎉

The release is available on:

Your semantic-release bot 📦🚀

@davidlj95 davidlj95 linked an issue Jan 15, 2024 that may be closed by this pull request
@davidlj95
Copy link
Owner Author

Ignore size comments, they're wrong. Given they didn't succeed first time given on a random CI failure. And second time they were generated comparing against themselves as this PR was merged and the last commit on main. Soo obviously no diff since code is same

@davidlj95
Copy link
Owner Author

From local markdown I can tell you we shaved 230 bytes on Angular v17 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce bundle size
1 participant